[Impeller] Delete any remaining GL objects during destruction of the ReactorGLES #56361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ReactorGLES At shutdown time the ReactorGLES may still be holding handles of GL objects. These objects should be cleaned up when the reactor is deleted. This leak can be seen by running DlGoldenTest.ShimmerTest, which takes a series of screenshots. Each screenshot creates an AiksContext. Without this change, the textures in the AiksContext's ReactorGLES will be leaked after the AiksContext is destroyed.
chinmaygarde
reviewed
Nov 4, 2024
| @@ -23,7 +72,13 @@ ReactorGLES::ReactorGLES(std::unique_ptr<ProcTableGLES> gl) | |||
| is_valid_ = true; | |||
| } | |||
|
|
|||
| ReactorGLES::~ReactorGLES() = default; | |||
| ReactorGLES::~ReactorGLES() { | |||
| for (auto& handle : handles_) { | |||
There was a problem hiding this comment.
This needs to be guarded by a CanReactOnCurrentThread. Otherwise, there is no guarantee that the thread can actually perform OpenGL operations. Perhaps there should be a shutdown method that can be explicitly called in addition to being called from the destructor. If there are pending handles and there can be no reactions on the current thread, then we could just log.
There was a problem hiding this comment.
Added a CanReactOnCurrentThread check.
Unfortunately, there does not seem to be an obvious place for the shell to clean up the ReactorGLES on a reactor worker thread during shutdown. The ReactorGLES is not deleted until the PlatformView is deleted on the platform thread in the final phase of shell shutdown.
The shell will be relying on destruction of the EGL context to clean up these objects.
chinmaygarde
approved these changes
Nov 4, 2024
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
…on of the ReactorGLES (flutter/engine#56361)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
…on of the ReactorGLES (flutter/engine#56361)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2024
…158218) flutter/engine@e5e06c9...a3741d6 2024-11-05 jason-simmons@users.noreply.github.com Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders (flutter/engine#56387) 2024-11-05 chris@bracken.jp iOS: Use standard Obj-C cflags for ios_test_flutter (flutter/engine#56384) 2024-11-05 robert.ancell@canonical.com Remove unnecessary method for getting engine switches (command line). (flutter/engine#56265) 2024-11-05 robert.ancell@canonical.com Remove FlScrollingViewDelegate (flutter/engine#56270) 2024-11-05 chris@bracken.jp fml: delete scoped_nsobject.h,mm (flutter/engine#56382) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (flutter/engine#56383) 2024-11-05 jason-simmons@users.noreply.github.com [Impeller] Delete any remaining GL objects during destruction of the ReactorGLES (flutter/engine#56361) 2024-11-05 mdebbar@google.com [web] Switch all fonts to WOFF2 (non-split) (flutter/engine#56035) 2024-11-05 jonahwilliams@google.com [Impeller] exploit content context options' perfect hash function. (flutter/engine#56360) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (flutter/engine#56380) 2024-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (flutter/engine#56377) 2024-11-05 jonahwilliams@google.com [Impeller] match Skia's old VMA default block size. (flutter/engine#56368) 2024-11-05 chris@bracken.jp iOS: Refactor ShellTestPlatformViewMetal (flutter/engine#56370) 2024-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... (flutter/engine#56374) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from amgHXcqtplha to z1otZzn3yKuG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ReactorGLES (flutter/engine#56361) At shutdown time the ReactorGLES may still be holding handles of GL objects. These objects should be cleaned up when the reactor is deleted. This leak can be seen by running DlGoldenTest.ShimmerTest, which takes a series of screenshots. Each screenshot creates an AiksContext. Without this change, the textures in the AiksContext's ReactorGLES will be leaked after the AiksContext is destroyed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At shutdown time the ReactorGLES may still be holding handles of GL objects. These objects should be cleaned up when the reactor is deleted.
This leak can be seen by running DlGoldenTest.ShimmerTest, which takes a series of screenshots. Each screenshot creates an AiksContext. Without this change, the textures in the AiksContext's ReactorGLES will be leaked after the AiksContext is destroyed.