iOS: Use standard Obj-C cflags for ios_test_flutter #56384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
requested review from
stuartmorgan,
jmagman,
loic-sharma and
hellohuanlin
cbracken
force-pushed
the
arc-ios-unittests
branch
from
e8b54cc to
82b4485
Compare
Previously, we had not enabled standard iOS cflags for `ios_test_flutter`, though ARC had been manually added to the cflags. This meant that the following flags were not enabled: * -Werror=overriding-method-mismatch * -Werror=undeclared-selector Both of these existed in the code within this target: * undeclared-selector: `insertionPointColor` was a non-public selector on UITextInput prior to iOS 17. * overriding-method-mismatch: `FakeFlutterUndoManagerDelegate`, which implements the `FlutterUndoManagerDelegate` protocol, declared `initWithUndoManager:activeInputView:` with a different type for `activeInputView`. This was a hack to jam in a test mock object that didn't match the required type for the property. Conveniently we have a class (`FlutterTextInputView`) that implements the required type and protocol (`UIView<UITextInput>`).
cbracken
force-pushed
the
arc-ios-unittests
branch
from
82b4485 to
a29dc19
Compare
jmagman
approved these changes
Nov 5, 2024
shell/platform/darwin/ios/framework/Source/FlutterUndoManagerPluginTest.mm
Show resolved
Hide resolved
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2024
…158218) flutter/engine@e5e06c9...a3741d6 2024-11-05 jason-simmons@users.noreply.github.com Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders (flutter/engine#56387) 2024-11-05 chris@bracken.jp iOS: Use standard Obj-C cflags for ios_test_flutter (flutter/engine#56384) 2024-11-05 robert.ancell@canonical.com Remove unnecessary method for getting engine switches (command line). (flutter/engine#56265) 2024-11-05 robert.ancell@canonical.com Remove FlScrollingViewDelegate (flutter/engine#56270) 2024-11-05 chris@bracken.jp fml: delete scoped_nsobject.h,mm (flutter/engine#56382) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (flutter/engine#56383) 2024-11-05 jason-simmons@users.noreply.github.com [Impeller] Delete any remaining GL objects during destruction of the ReactorGLES (flutter/engine#56361) 2024-11-05 mdebbar@google.com [web] Switch all fonts to WOFF2 (non-split) (flutter/engine#56035) 2024-11-05 jonahwilliams@google.com [Impeller] exploit content context options' perfect hash function. (flutter/engine#56360) 2024-11-05 skia-flutter-autoroll@skia.org Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (flutter/engine#56380) 2024-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (flutter/engine#56377) 2024-11-05 jonahwilliams@google.com [Impeller] match Skia's old VMA default block size. (flutter/engine#56368) 2024-11-05 chris@bracken.jp iOS: Refactor ShellTestPlatformViewMetal (flutter/engine#56370) 2024-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... (flutter/engine#56374) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from amgHXcqtplha to z1otZzn3yKuG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…6384) Previously, we had not enabled standard iOS cflags for `ios_test_flutter`, though ARC had been manually added to the cflags. This meant that the following flags were not enabled: * -Werror=overriding-method-mismatch * -Werror=undeclared-selector Both of these existed in the code within this target: * undeclared-selector: `insertionPointColor` was a non-public selector on UITextInput prior to iOS 17. * overriding-method-mismatch: `FakeFlutterUndoManagerDelegate`, which implements the `FlutterUndoManagerDelegate` protocol, declared `initWithUndoManager:activeInputView:` with a different type for `activeInputView`. This was a hack to jam in a test mock object that didn't match the required type for the property. Conveniently we have a class (`FlutterTextInputView`) that implements the required type and protocol (`UIView<UITextInput>`). Issue: flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had not enabled standard iOS cflags for
ios_test_flutter, though ARC had been manually added to the cflags. This meant that the following flags were not enabled:Both of these existed in the code within this target:
insertionPointColorwas a non-public selector on UITextInput prior to iOS 17.FakeFlutterUndoManagerDelegate, which implements theFlutterUndoManagerDelegateprotocol, declaredinitWithUndoManager:activeInputView:with a different type foractiveInputView. This was a hack to jam in a test mock object that didn't match the required type for the property. Conveniently we have a class (FlutterTextInputView) that implements the required type and protocol (UIView<UITextInput>).Issue: flutter/flutter#137801
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.