This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Complete the AndroidView resize call only after a new frame is ready. #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the framework to know that a frame with the resized view is ready and to behave deterministically to workaround the jank issue described in flutter/flutter/19572
jason-simmons
approved these changes
Aug 8, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...8137d34 git log 08b660e..8137d34 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...69b19a5 git log 08b660e..69b19a5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...4208f84 git log 08b660e..4208f84 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...4c7e5d5 git log 08b660e..4c7e5d5 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977) 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...78f8bca git log 08b660e..78f8bca --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 keertip@users.noreply.github.com Annotate deprecated methods with @deprecated (flutter/engine#5976) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977) 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 8, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...3777931 git log 08b660e..3777931 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 a-siva@users.noreply.github.com Roll Dart to version eab492385c3f345cb2f44f3b702b0e30e4a9c107 (flutter/engine#5979) 2018-08-08 aam@google.com Fix IsolateStart event kind. (flutter/engine#5978) 2018-08-08 keertip@users.noreply.github.com Annotate deprecated methods with @deprecated (flutter/engine#5976) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977) 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2018
flutter/engine@08b660e...3501acb git log 08b660e..3501acb --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980) 2018-08-08 a-siva@users.noreply.github.com Roll Dart to version eab492385c3f345cb2f44f3b702b0e30e4a9c107 (flutter/engine#5979) 2018-08-08 aam@google.com Fix IsolateStart event kind. (flutter/engine#5978) 2018-08-08 keertip@users.noreply.github.com Annotate deprecated methods with @deprecated (flutter/engine#5976) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977) 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2018
flutter/engine@08b660e...91537ab git log 08b660e..91537ab --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980) 2018-08-08 a-siva@users.noreply.github.com Roll Dart to version eab492385c3f345cb2f44f3b702b0e30e4a9c107 (flutter/engine#5979) 2018-08-08 aam@google.com Fix IsolateStart event kind. (flutter/engine#5978) 2018-08-08 keertip@users.noreply.github.com Annotate deprecated methods with @deprecated (flutter/engine#5976) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977) 2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973) 2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970) 2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the framework to know that a frame with the resized view is
ready and to behave deterministically to workaround the jank issue
described in flutter/flutter/19572