Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pesto heroes animate above the app bar. #5961

Closed
dragostis opened this issue Sep 20, 2016 · 7 comments
Closed

Pesto heroes animate above the app bar. #5961

dragostis opened this issue Sep 20, 2016 · 7 comments
Labels
customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there.

Comments

@dragostis
Copy link
Contributor

When tapping a image (i.e. hero) that is below the app bar, the hero animation immediately places it on top (this particular animation is not so bad). When pressing the back button, the moment when the app bar comes back on top is late an noticeable, making the animation look janky.
@dragostis dragostis added ⚠ bug customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Sep 20, 2016
@dragostis
Copy link
Contributor Author

I see three simple solutions for this: either bring the app bar back up the moment you tap the button, or slide the app bar in and out when animating the hero animations, or scroll the view in the background. (last one is probably not desirable)

@Hixie Hixie modified the milestone: 4: Make Hixie proud Nov 29, 2016
@eseidelGoogle
Copy link
Contributor

This might just be #5350 ? which seems like it's asking for #5232?

@eseidelGoogle
Copy link
Contributor

#4442 also sounds related, but for Shrine?

@eseidelGoogle
Copy link
Contributor

Looks like @HansMuller put this in Heros2 so he can decide how to track this.

@HansMuller
Copy link
Contributor

This is a duplicate of #5350, see #5350 (comment)

@eseidelGoogle
Copy link
Contributor

Closing on hans' behalf.

Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Aug 9, 2018
@engine-flutter-autoroll
Roll engine 08b660e..91537ab (12 commits)
e03ae8c 
flutter/engine@08b660e...91537ab

git log 08b660e..91537ab --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980)
2018-08-08 a-siva@users.noreply.github.com Roll Dart to version eab492385c3f345cb2f44f3b702b0e30e4a9c107 (flutter/engine#5979)
2018-08-08 aam@google.com Fix IsolateStart event kind. (flutter/engine#5978)
2018-08-08 keertip@users.noreply.github.com Annotate deprecated methods with @deprecated (flutter/engine#5976)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0c5b0b1dd692..9c9611fcc1bb (13 commits) (flutter/engine#5977)
2018-08-08 jonahwilliams@google.com make ios text affinity behavior match android (flutter/engine#5971)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f5402004c4a6..0c5b0b1dd692 (11 commits) (flutter/engine#5975)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 4856f5fa596d..f5402004c4a6 (1 commits) (flutter/engine#5974)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 20714bdf90f3..4856f5fa596d (1 commits) (flutter/engine#5973)
2018-08-07 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia faeef7837210..20714bdf90f3 (11 commits) (flutter/engine#5970)
2018-08-07 amirh@users.noreply.github.com Complete the AndroidView resize call only after a new frame is ready. (flutter/engine#5968)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Aug 9, 2018
@engine-flutter-autoroll
Roll engine 3777931..764884b (3 commits)
284915a 
flutter/engine@3777931...764884b

git log 3777931..764884b --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983)
2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Aug 9, 2018
@engine-flutter-autoroll
Roll engine 3777931..e54bc4e (4 commits)
c1572bb 
flutter/engine@3777931...e54bc4e

git log 3777931..e54bc4e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-09 bkonyi@google.com Fixed invalid call site of runWithEntrypointAndCallback (flutter/engine#5984)
2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983)
2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
Closed
@a-siva a-siva mentioned this issue Aug 9, 2018
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Aug 10, 2018
@engine-flutter-autoroll
Roll engine 3777931..d90223f (5 commits)
32b05a9 
flutter/engine@3777931...d90223f

git log 3777931..d90223f --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)
2018-08-09 bkonyi@google.com Fixed invalid call site of runWithEntrypointAndCallback (flutter/engine#5984)
2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983)
2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966)
2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
Closed
a-siva added a commit that referenced this issue Aug 10, 2018
@a-siva
Roll engine to version e54bc4e
6146c0f 
This includes the following changes :

e54bc4e Fixed invalid call site of runWithEntrypointAndCallback (#5984)
764884b Removed callback for HeadlessDartRunner (#5983)
91537ab Revert "Temporarily add travis/analyze.sh back for Chrome bot (#5961)" (#5966)
3501acb Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (#5980)
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hixie @HansMuller @dragostis @eseidelGoogle