This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Removed callback for HeadlessDartRunner #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Aug 9, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2018
flutter/engine@3777931...764884b git log 3777931..764884b --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983) 2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
jamesderlin
reviewed
Aug 9, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2018
flutter/engine@3777931...e54bc4e git log 3777931..e54bc4e --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-09 bkonyi@google.com Fixed invalid call site of runWithEntrypointAndCallback (flutter/engine#5984) 2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983) 2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2018
flutter/engine@3777931...d90223f git log 3777931..d90223f --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985) 2018-08-09 bkonyi@google.com Fixed invalid call site of runWithEntrypointAndCallback (flutter/engine#5984) 2018-08-09 bkonyi@google.com Removed callback for HeadlessDartRunner (flutter/engine#5983) 2018-08-08 liyuqian@google.com Revert "Temporarily add travis/analyze.sh back for Chrome bot (flutter#5961)" (flutter/engine#5966) 2018-08-08 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 9c9611fcc1bb..0d5d0659a684 (7 commits) (flutter/engine#5980) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be somewhat consistent with the Android interface where we decided against having a callback for when the created by a background shell is entered.