Remove obsolete discovery mechanism from FlutterView #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Sep 4, 2018
cbracken
approved these changes
Sep 4, 2018
|
|
|
Can we get some historical context for the record? What was this used for previously and why is it no longer needed? PS - I just removed the same thing from my refactor work to match this PR. |
|
This was added to provide a way for IDE users to attach the debugger to a running Flutter app that wasn't launched through the IDE. The tooling would issue a broadcast intent via adb, and all Flutter apps running on the device in debug mode would respond by writing an observatory endpoint to the Android log. The IDE could then ask the user to select an app and then establish a debug connection. I had implemented this flow as an experiment in the old Flutter Atom plugin, but I don't think it got much use. The current tools do not make use of this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2018
flutter/engine@de4c7a5...3a7d0b5 git log de4c7a5..3a7d0b5 --no-merges --oneline 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2018
flutter/engine@de4c7a5...0981731 git log de4c7a5..0981731 --no-merges --oneline 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2018
flutter/engine@de4c7a5...e6d9b34 git log de4c7a5..e6d9b34 --no-merges --oneline e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2018
flutter/engine@de4c7a5...a0f30b3 git log de4c7a5..a0f30b3 --no-merges --oneline a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...f6ad3e0 git log de4c7a5..f6ad3e0 --no-merges --oneline f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...108e0a6 git log de4c7a5..108e0a6 --no-merges --oneline 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...572753f git log de4c7a5..572753f --no-merges --oneline 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Sep 6, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...ade0f22 git log de4c7a5..ade0f22 --no-merges --oneline ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...1768bed git log de4c7a5..1768bed --no-merges --oneline 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...897178c git log de4c7a5..897178c --no-merges --oneline 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...5f61056 git log de4c7a5..5f61056 --no-merges --oneline 5f61056 Revert "Dart SDK roll for 2018/09/04 (flutter#6161)" (flutter/engine#6183) 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@de4c7a5...5f61056 git log de4c7a5..5f61056 --no-merges --oneline 5f61056 Revert "Dart SDK roll for 2018/09/04 (#6161)" (flutter/engine#6183) 897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182) 1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181) ade0f22 Remove unused file picture_serializer. (flutter/engine#6179) 572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178) 108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172) f6ad3e0 Roll Tonic (flutter/engine#6177) a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175) e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170) 9f0ad8b Fixes negative end selection offset. (flutter/engine#6171) 0981731 Enable transparent FlutterViews (flutter/engine#6163) 3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169) 564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168) 6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157) b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161) 6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167) 5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166) 19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165) 9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164) 6ad3183 Fix windows build. (flutter/engine#6162) 30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159) b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156) c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155) aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154) 593ed59 Revert "Use Skia normalize again after Skia precision fix. (#6121)" (flutter/engine#6122) 137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153) f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152) b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079) 2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151) eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148) bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
matthew-carroll
pushed a commit
to matthew-carroll/engine
that referenced
this pull request
Sep 7, 2018
matthew-carroll
pushed a commit
to matthew-carroll/engine
that referenced
this pull request
Sep 7, 2018
matthew-carroll
pushed a commit
to matthew-carroll/engine
that referenced
this pull request
Sep 7, 2018
matthew-carroll
added a commit
that referenced
this pull request
Sep 19, 2018
…erer (#6195) * Copied over FlutterView. Copied a number of dependencies due to package change. Grouped related methods within FlutterView. Deleted a few unused methods. * Moved BinaryMessenger out of FlutterView and into FlutterEngine, moved native calls from FlutterView to FlutterEngine. * Introduced concept of a FlutterRenderer. It doesn't have any meaningful behavior yet. Need strategy for resolving FlutterNativeView vs FlutterEngine first. * Removed discovery behavior from FlutterView to match recent PR: #6157 * Replaced FlutterNativeView with FlutterEngine and FlutterRenderer. Eliminated FlutterEngine references from within FlutterView. Centralized all JNI calls within a FlutterJNI and updated the C side accordingly. * Added comments to FlutterEngine, FlutterRender, FlutterFragment, and FlutterView. * Removed some extraneous code. Adjusted first frame notification slightly. * Fixed formatting in platform_view_android_jni.cc * Update licenses file. * Exposed FlutterEngine from plugin system. Updated some access modifiers as needed. * PR Updates.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
…erer (flutter#6195) * Copied over FlutterView. Copied a number of dependencies due to package change. Grouped related methods within FlutterView. Deleted a few unused methods. * Moved BinaryMessenger out of FlutterView and into FlutterEngine, moved native calls from FlutterView to FlutterEngine. * Introduced concept of a FlutterRenderer. It doesn't have any meaningful behavior yet. Need strategy for resolving FlutterNativeView vs FlutterEngine first. * Removed discovery behavior from FlutterView to match recent PR: flutter#6157 * Replaced FlutterNativeView with FlutterEngine and FlutterRenderer. Eliminated FlutterEngine references from within FlutterView. Centralized all JNI calls within a FlutterJNI and updated the C side accordingly. * Added comments to FlutterEngine, FlutterRender, FlutterFragment, and FlutterView. * Removed some extraneous code. Adjusted first frame notification slightly. * Fixed formatting in platform_view_android_jni.cc * Update licenses file. * Exposed FlutterEngine from plugin system. Updated some access modifiers as needed. * PR Updates.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
…erer (flutter#6195) * Copied over FlutterView. Copied a number of dependencies due to package change. Grouped related methods within FlutterView. Deleted a few unused methods. * Moved BinaryMessenger out of FlutterView and into FlutterEngine, moved native calls from FlutterView to FlutterEngine. * Introduced concept of a FlutterRenderer. It doesn't have any meaningful behavior yet. Need strategy for resolving FlutterNativeView vs FlutterEngine first. * Removed discovery behavior from FlutterView to match recent PR: flutter#6157 * Replaced FlutterNativeView with FlutterEngine and FlutterRenderer. Eliminated FlutterEngine references from within FlutterView. Centralized all JNI calls within a FlutterJNI and updated the C side accordingly. * Added comments to FlutterEngine, FlutterRender, FlutterFragment, and FlutterView. * Removed some extraneous code. Adjusted first frame notification slightly. * Fixed formatting in platform_view_android_jni.cc * Update licenses file. * Exposed FlutterEngine from plugin system. Updated some access modifiers as needed. * PR Updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.