Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Dart SDK roll for 2018/09/04 (#6161)" #6183

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Revert "Dart SDK roll for 2018/09/04 (#6161)" #6183

merged 2 commits into from
Sep 6, 2018

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Sep 6, 2018 •
edited
Loading

This reverts commit b22badf.
FlutterTesterDevice (in packages/flutter_tools/test/integration/flutter_tester_test.dart) is failing:

../../bin/cache/dart-sdk/bin/dart test/integration/flutter_tester_test.dart
00:00 +0: FlutterTesterDevice start
00:00 +0 -1: FlutterTesterDevice start [E]
  Bad state: Invalid script: file:///tmp/flutter_tester_device_test.EAPFMQ/test/integration/flutter_tester_test.dart

@bkonyi bkonyi requested a review from zanderso September 6, 2018 16:02
zanderso
zanderso approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note about the reason for the revert.

@bkonyi bkonyi merged commit 5f61056 into master Sep 6, 2018
@bkonyi bkonyi deleted the dart-roll-revert branch September 6, 2018 16:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 6, 2018
@engine-flutter-autoroll
Roll engine de4c7a5..5f61056 (31 commits)
de437fc 
flutter/engine@de4c7a5...5f61056

git log de4c7a5..5f61056 --no-merges --oneline
5f61056 Revert "Dart SDK roll for 2018/09/04 (flutter#6161)" (flutter/engine#6183)
897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182)
1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181)
ade0f22 Remove unused file picture_serializer. (flutter/engine#6179)
572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178)
108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172)
f6ad3e0 Roll Tonic (flutter/engine#6177)
a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175)
e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170)
9f0ad8b Fixes negative end selection offset. (flutter/engine#6171)
0981731 Enable transparent FlutterViews (flutter/engine#6163)
3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169)
564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168)
6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157)
b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161)
6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167)
5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166)
19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165)
9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164)
6ad3183 Fix windows build. (flutter/engine#6162)
30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159)
b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156)
c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155)
aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154)
593ed59 Revert "Use Skia normalize again after Skia precision fix. (flutter#6121)" (flutter/engine#6122)
137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153)
f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152)
b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079)
2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151)
eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148)
bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2018
Merged
liyuqian pushed a commit to flutter/flutter that referenced this pull request Sep 6, 2018
@engine-flutter-autoroll @liyuqian
Roll engine de4c7a5..5f61056 (31 commits) (#21502)
358822e 
flutter/engine@de4c7a5...5f61056

git log de4c7a5..5f61056 --no-merges --oneline
5f61056 Revert "Dart SDK roll for 2018/09/04 (#6161)" (flutter/engine#6183)
897178c Roll src/third_party/skia 71f8475a0dba..33d3d31a7e28 (6 commits) (flutter/engine#6182)
1768bed Roll src/third_party/skia ffbcc3fadfa1..71f8475a0dba (3 commits) (flutter/engine#6181)
ade0f22 Remove unused file picture_serializer. (flutter/engine#6179)
572753f Roll src/third_party/skia 343553a1fe9e..ffbcc3fadfa1 (6 commits) (flutter/engine#6178)
108e0a6 Add transparency helpers to FlutterView.java (flutter/engine#6172)
f6ad3e0 Roll Tonic (flutter/engine#6177)
a0f30b3 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175)
e6d9b34 Remove the old location of the ICU data asset (flutter/engine#6170)
9f0ad8b Fixes negative end selection offset. (flutter/engine#6171)
0981731 Enable transparent FlutterViews (flutter/engine#6163)
3a7d0b5 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169)
564d214 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168)
6af60d7 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157)
b22badf Dart SDK roll for 2018/09/04 (flutter/engine#6161)
6d0fbc7 Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167)
5063a8a Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166)
19a3bc8 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165)
9643a50 Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164)
6ad3183 Fix windows build. (flutter/engine#6162)
30af2f2 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159)
b32ceaf Add some more logs for diagnosing screenshot failures (flutter/engine#6156)
c173655 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155)
aaf98fb Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154)
593ed59 Revert "Use Skia normalize again after Skia precision fix. (#6121)" (flutter/engine#6122)
137389a Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153)
f89a386 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152)
b0b8daa Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079)
2dc8271 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151)
eea3a21 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148)
bdcbe80 Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@bkonyi @amirh
Revert "Dart SDK roll for 2018/09/04 (flutter#6161)" (flutter#6183)
914cebc 
* Revert "Dart SDK roll for 2018/09/04 (flutter#6161)"

This reverts commit b22badf.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@bkonyi
Revert "Dart SDK roll for 2018/09/04 (flutter#6161)" (flutter#6183)
4477cfb 
* Revert "Dart SDK roll for 2018/09/04 (flutter#6161)"

This reverts commit b22badf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyuqian liyuqian liyuqian approved these changes

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkonyi @zanderso @liyuqian @googlebot