This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Dart to ef720983530e04819b6fda0659ed7a3fdb190060. #6212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-siva
approved these changes
Sep 10, 2018
| }; | ||
|
|
||
| static const char* kDartStrongModeArgs[] = { | ||
| static const char* kDartModeArgs[] = { |
Contributor
There was a problem hiding this comment.
Maybe name the variable kDart1ModeArgs ?
I understand this is a short term fix until your next CL lands, so ignore the comment if you think the CL to remove this is going to land soon.
Contributor
Author
There was a problem hiding this comment.
"Dart" is more accurate, but yes this will be removed in my next CL.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2018
flutter/engine@d52e5cc...f19ee56 git log d52e5cc..f19ee56 --no-merges --oneline f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) e65beb8 Roll Dart to ef720983530e04819b6fda0659ed7a3fdb190060. (flutter/engine#6212) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2018
flutter/engine@d52e5cc...1fb01f3 git log d52e5cc..1fb01f3 --no-merges --oneline 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) e65beb8 Roll Dart to ef720983530e04819b6fda0659ed7a3fdb190060. (flutter/engine#6212) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ef72098 [VM] Add new SymbolConstant to package:kernel/ast.dart
44679be Add script to add commit hash and metadata to the json record of a test.py run.
14cf371 [VM] Do not generate fall-through code if the intrinsic is exhaustive (handles all cases)
f8633ae Move KernelToElementMapForBuilding and friends to js_model/element_map*
88bff73 Inline element map mixins that are only applied once
8c03bff Step towards splitting element maps in K/J versions
c4bfa60 Add first step of an in-memory serialization test
e311e12 Move all data for collection for testing behind one flag
1cd9cae [gardening] Mark vm/cc/CustomIsolates as Crashing
e0f0f4b [gardening] Mark service/regexp_function_test as flaky
b72b006 [infra] Fix typo in test matrix (#32229)
bdfa1b7 [VM] Fix memory leak in run_vm_tests
a6c7647 [gardening] Mark service/regexp_test as Crashing on windows
dd2cf0e Fix unittest path
5cba87a Test that the run_vm_tests benchmarks continue to work.
e1fe4d4 Remove type inferrer from generators
c42bde5 Remove type-inference listener
6616dde Move dart2js unittests to subfolders
f3036f4 Support supermixins in dart2js
5e26304 Enable StrongModeWorldStrategy
9e3bcc4 Report MIXIN_INSTANTIATE when a mixin is instantiated.
e20af73 Triage Analyzer language_2 failures for mixin declarations.
c925fa6 Lay the groundwork for comparing language_2 compilation results between analyzer and CFE.
4ef1ad0 Update the language spec to allow
withclause without anextendsclausee62a208 Fix benchmark runs.
9795cd9 Remove uses of DartType from const expression serialization.
13efc4f Convert test_strategies.dart to triple-slash comment style.
eb8350a Adjust status settings for service/rewind_test.dart
c4d3507 [vm] Don't build the kernel service snapshot if the platform dill has bytecode
134bb88 Handle generic types in native behavior
d66572d [vm, arm64] Eliminate some no-ops already filtered from the other architectures.
be5cd63 fix #34296, generic function instantiation should be checked eagerly
cd3dded Move flags strong/sync-async/reify-generic-functions back to global vm flags (they are not set as isolate specific flags).
3903b5b [vm] Fix passing --enable_interpreter in tests.