Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Sep 10, 2018

Reduces visibility of symbols, which decreases libflutter.so by ~28KB in combination with the LTO PR.

@chinmaygarde
Copy link
Member

Did the license check really just say this is fine without changes?

@jason-simmons
Copy link
Member

This is just a change in build flags. The FreeType source is still at the same version.

@goderbauer goderbauer merged commit f19ee56 into flutter:master Sep 10, 2018
@goderbauer goderbauer deleted the rollFreetype branch September 10, 2018 21:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 10, 2018
flutter/engine@d52e5cc...f19ee56

git log d52e5cc..f19ee56 --no-merges --oneline
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)
e65beb8 Roll Dart to ef720983530e04819b6fda0659ed7a3fdb190060. (flutter/engine#6212)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 10, 2018
flutter/engine@d52e5cc...1fb01f3

git log d52e5cc..1fb01f3 --no-merges --oneline
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)
e65beb8 Roll Dart to ef720983530e04819b6fda0659ed7a3fdb190060. (flutter/engine#6212)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...e3133e0

git log e65beb8..e3133e0 --no-merges --oneline
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...8f39cac

git log e65beb8..8f39cac --no-merges --oneline
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...8d9e20c

git log e65beb8..8d9e20c --no-merges --oneline
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...6ed00a8

git log e65beb8..6ed00a8 --no-merges --oneline
6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...51b26f6

git log e65beb8..51b26f6 --no-merges --oneline
51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223)
7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222)
54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221)
35ddf87 Roll buildroot to eba79bb (flutter/engine#6215)
6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2018
flutter/engine@e65beb8...9a173a8

git log e65beb8..9a173a8 --no-merges --oneline
9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224)
51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223)
7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222)
54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221)
35ddf87 Roll buildroot to eba79bb (flutter/engine#6215)
6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 12, 2018
flutter/engine@e65beb8...0ded891

git log e65beb8..0ded891 --no-merges --oneline
0ded891 Roll src/third_party/skia 1b5ece0f06f4..e70aed7066c6 (1 commits) (flutter/engine#6231)
4057327 Roll src/third_party/skia bd6595544171..1b5ece0f06f4 (22 commits) (flutter/engine#6229)
838eb3d Improve performance of performance overlay by caching. (flutter/engine#6225)
7ac3345 Remove root_surface_transformation from PaintContext (flutter/engine#6213)
565a194 Flutter roll for Dart. (flutter/engine#6227)
9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224)
51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223)
7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222)
54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221)
35ddf87 Roll buildroot to eba79bb (flutter/engine#6215)
6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 12, 2018
flutter/engine@e65beb8...6f459e2

git log e65beb8..6f459e2 --no-merges --oneline
6f459e2 Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (flutter#6216)" (flutter/engine#6232)
0ded891 Roll src/third_party/skia 1b5ece0f06f4..e70aed7066c6 (1 commits) (flutter/engine#6231)
4057327 Roll src/third_party/skia bd6595544171..1b5ece0f06f4 (22 commits) (flutter/engine#6229)
838eb3d Improve performance of performance overlay by caching. (flutter/engine#6225)
7ac3345 Remove root_surface_transformation from PaintContext (flutter/engine#6213)
565a194 Flutter roll for Dart. (flutter/engine#6227)
9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224)
51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223)
7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222)
54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221)
35ddf87 Roll buildroot to eba79bb (flutter/engine#6215)
6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants