Reapply "Some cleanups enabled by removing support for Dart 1." #6216

rmacnak-google · 2018-09-10T21:45:06Z

Add missing Dart 2 flags to gen_snapshot invocation.
Disable brittle service test.

- Switch core snapshot to Dart 2 and remove support for loading platform.dill. - Remove support for loading script snapshots. - Remove support for loading source. - Remove settings and fix names to reflect the above. - Remove support for loading the service isolate from source.

rmacnak-google · 2018-09-10T22:01:46Z

lib/snapshot/BUILD.gn

+    args = [
+      "--strong",
+      "--sync-async",
+      "--reify-generic-functions",


New part here.

rmacnak-google · 2018-09-10T22:02:06Z

shell/testing/observatory/test.dart


 final List<TestFunction> startPausedTests = <TestFunction>[
-  testStartPaused,
+  // TODO(engine): Investigate difference in lifecycle events.


cbracken · 2018-09-11T00:01:40Z

cbracken · 2018-09-11T00:04:03Z

This re-hammers-in the final nail in the coffin of flutter/flutter#17051.

flutter/engine@e65beb8...e3133e0 git log e65beb8..e3133e0 --no-merges --oneline e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...8f39cac git log e65beb8..8f39cac --no-merges --oneline 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...8d9e20c git log e65beb8..8d9e20c --no-merges --oneline 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...6ed00a8 git log e65beb8..6ed00a8 --no-merges --oneline 6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220) 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...51b26f6 git log e65beb8..51b26f6 --no-merges --oneline 51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223) 7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222) 54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221) 35ddf87 Roll buildroot to eba79bb (flutter/engine#6215) 6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220) 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...9a173a8 git log e65beb8..9a173a8 --no-merges --oneline 9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224) 51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223) 7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222) 54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221) 35ddf87 Roll buildroot to eba79bb (flutter/engine#6215) 6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220) 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@e65beb8...0ded891 git log e65beb8..0ded891 --no-merges --oneline 0ded891 Roll src/third_party/skia 1b5ece0f06f4..e70aed7066c6 (1 commits) (flutter/engine#6231) 4057327 Roll src/third_party/skia bd6595544171..1b5ece0f06f4 (22 commits) (flutter/engine#6229) 838eb3d Improve performance of performance overlay by caching. (flutter/engine#6225) 7ac3345 Remove root_surface_transformation from PaintContext (flutter/engine#6213) 565a194 Flutter roll for Dart. (flutter/engine#6227) 9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224) 51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223) 7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222) 54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221) 35ddf87 Roll buildroot to eba79bb (flutter/engine#6215) 6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220) 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

…." (flutter#6216)" This reverts commit e3133e0.

goderbauer · 2018-09-12T09:45:11Z

This seems to break coverage: https://build.chromium.org/p/client.flutter/builders/Linux/builds/6716/steps/run%20test.dart%20for%20coverage%20shard/logs/stdio

I'll revert it shortly.

#6216)" (#6232) This reverts commit e3133e0.

flutter/engine@e65beb8...6f459e2 git log e65beb8..6f459e2 --no-merges --oneline 6f459e2 Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (flutter#6216)" (flutter/engine#6232) 0ded891 Roll src/third_party/skia 1b5ece0f06f4..e70aed7066c6 (1 commits) (flutter/engine#6231) 4057327 Roll src/third_party/skia bd6595544171..1b5ece0f06f4 (22 commits) (flutter/engine#6229) 838eb3d Improve performance of performance overlay by caching. (flutter/engine#6225) 7ac3345 Remove root_surface_transformation from PaintContext (flutter/engine#6213) 565a194 Flutter roll for Dart. (flutter/engine#6227) 9a173a8 Roll buldroot to a11c4fd (flutter/engine#6224) 51b26f6 Revert "Roll buildroot to eba79bb (flutter#6215)" (flutter/engine#6223) 7be4462 Roll src/third_party/skia 2bf7a7bcc67f..bd6595544171 (4 commits) (flutter/engine#6222) 54fe12b Roll src/third_party/skia 82bf31003c66..2bf7a7bcc67f (1 commits) (flutter/engine#6221) 35ddf87 Roll buildroot to eba79bb (flutter/engine#6215) 6ed00a8 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220) 8d9e20c Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219) 8f39cac Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218) e3133e0 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216) 1fb01f3 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217) f19ee56 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

…ter#6216) - Add missing Dart 2 flags to gen_snapshot invocation. - Disable brittle service test.

flutter#6216)" (flutter#6232) This reverts commit e3133e0.

…ter#6216) - Add missing Dart 2 flags to gen_snapshot invocation. - Disable brittle service test.

flutter#6216)" (flutter#6232) This reverts commit e3133e0.

googlebot added the cla: yes label Sep 10, 2018

rmacnak-google changed the title ~~Reapply "Some cleanups enabled by removing support for Dart."~~ Reapply "Some cleanups enabled by removing support for Dart 1." Sep 10, 2018

rmacnak-google commented Sep 10, 2018

View reviewed changes

lib/snapshot/BUILD.gn

args = [

"--strong",

"--sync-async",

"--reify-generic-functions",

Copy link

Contributor Author

rmacnak-google Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New part here.

rmacnak-google commented Sep 10, 2018

View reviewed changes

rmacnak-google requested review from a-siva and cbracken September 10, 2018 22:02

cbracken approved these changes Sep 11, 2018

View reviewed changes

rmacnak-google merged commit e3133e0 into flutter:master Sep 11, 2018

This was referenced Sep 11, 2018

Roll engine e65beb89da8b..e3133e0e3f7c (3 commits) flutter/flutter#21661

Closed

Roll engine e65beb89da8b..8f39cac12c98 (4 commits) flutter/flutter#21664

Closed

This was referenced Sep 11, 2018

Roll engine e65beb89da8b..8d9e20c021dd (5 commits) flutter/flutter#21671

Closed

Roll engine e65beb89da8b..6ed00a868860 (6 commits) flutter/flutter#21676

Closed

engine-flutter-autoroll mentioned this pull request Sep 11, 2018

Roll engine e65beb89da8b..51b26f6347f7 (10 commits) flutter/flutter#21689

Closed

engine-flutter-autoroll mentioned this pull request Sep 11, 2018

Roll engine e65beb89da8b..9a173a8dc845 (11 commits) flutter/flutter#21691

Closed

engine-flutter-autoroll mentioned this pull request Sep 12, 2018

Roll engine e65beb89da8b..0ded891881db (16 commits) flutter/flutter#21718

Closed

goderbauer added a commit to goderbauer/engine that referenced this pull request Sep 12, 2018

Revert "Reapply "Some cleanups enabled by removing support for Dart 1…

88f8ee3

…." (flutter#6216)" This reverts commit e3133e0.

goderbauer mentioned this pull request Sep 12, 2018

Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (#6216)" #6232

Merged

goderbauer added a commit that referenced this pull request Sep 12, 2018

Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (

6f459e2

#6216)" (#6232) This reverts commit e3133e0.

engine-flutter-autoroll mentioned this pull request Sep 12, 2018

Roll engine e65beb89da8b..6f459e2f10ca (17 commits) flutter/flutter#21725

Closed

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Reapply "Some cleanups enabled by removing support for Dart 1." (flut…

bfca954

…ter#6216) - Add missing Dart 2 flags to gen_snapshot invocation. - Disable brittle service test.

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (

a96a9d6

flutter#6216)" (flutter#6232) This reverts commit e3133e0.

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Reapply "Some cleanups enabled by removing support for Dart 1." (flut…

6936669

…ter#6216) - Add missing Dart 2 flags to gen_snapshot invocation. - Disable brittle service test.

amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018

Revert "Reapply "Some cleanups enabled by removing support for Dart 1" (

9430a48

flutter#6216)" (flutter#6232) This reverts commit e3133e0.

rmacnak-google deleted the cleanup branch November 1, 2018 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reapply "Some cleanups enabled by removing support for Dart 1." #6216

Reapply "Some cleanups enabled by removing support for Dart 1." #6216

Uh oh!

rmacnak-google commented Sep 10, 2018 •

edited

Loading

Uh oh!

rmacnak-google Sep 10, 2018

Uh oh!

rmacnak-google Sep 10, 2018

Uh oh!

cbracken commented Sep 11, 2018

Uh oh!

cbracken commented Sep 11, 2018 •

edited

Loading

Uh oh!

goderbauer commented Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Reapply "Some cleanups enabled by removing support for Dart 1." #6216

Reapply "Some cleanups enabled by removing support for Dart 1." #6216

Uh oh!

Conversation

rmacnak-google commented Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmacnak-google Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

rmacnak-google Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

cbracken commented Sep 11, 2018

Uh oh!

cbracken commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer commented Sep 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rmacnak-google commented Sep 10, 2018 •

edited

Loading

cbracken commented Sep 11, 2018 •

edited

Loading