This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reimplement 'stretch' for flexible items correctly. #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter#698 to actually work. Also, adds some debugging aids around Flex. And a test to check this fix.
Contributor
|
LGTM |
Contributor
Author
|
The test failure (CC @abarth) seems unrelated (and I didn't hit it when developing?), so I'm merging this in. |
Hixie
added a commit
that referenced
this pull request
Aug 22, 2015
Reimplement 'stretch' for flexible items correctly.
Contributor
|
I think it's an issue with the new harness being flaky. :( |
Contributor
|
Thank you! |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Add support for set literals.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Remove misleading wording in VkDescriptorBufferInfo::buffer comment
qadevices
pushed a commit
to qadevices/engine
that referenced
this pull request
Oct 3, 2023
The Clang 18 roll here flutter#45486 will add a new warning like: we get errors of the form: ``` ../../third_party/json/include\nlohmann/json.hpp(5142,35): error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator] 5142 | inline nlohmann::json operator "" _json(const char* s, std::size_t n) | ~~~~~~~~~~~~^~~~~ | operator""_json ``` That is, Clang rejects `operator "" _a` unless spaces are removed. This PR adds a flag to silence the warning util it is fixed upstream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698 to actually work.
Also, adds some debugging aids around Flex.
And a test to check this fix.