Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed. [prod-leak-fix] #136615

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed. [prod-leak-fix] #136615

merged 7 commits into from
Oct 16, 2023

Conversation

droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 16, 2023

Description

As a part of Issue: #134 this PR includes coverage for test/cupertino/ by changing testWidgets to testWidgetsWithLeakTracking .

Tests

  • Updates search_field_test.dart to use testWidgetsWithLeakTracking.
  • Fixed RestorableTextEditingController and TextEditingController not disposed in search_field_test.dart by changing search_field.dart .

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 16, 2023
@droidbg droidbg marked this pull request as ready for review October 16, 2023 15:36
@droidbg
Copy link
Contributor Author

droidbg commented Oct 16, 2023

cc: @polina-c could you pls review it?

@polina-c polina-c merged commit ce3e81d into flutter:master Oct 16, 2023
59 checks passed
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
4de1141 
…TextEditingController not disposed. (flutter/flutter#136615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
7fe0038 
…TextEditingController not disposed. (flutter/flutter#136615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
49530ff 
…TextEditingController not disposed. (flutter/flutter#136615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
78f9e1d 
…TextEditingController not disposed. (flutter/flutter#136615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
2ada79b 
…TextEditingController not disposed. (flutter/flutter#136615)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
ce3e81d Cupertino search field test leak tracking and Fix. Restorable…
cc33836 
…TextEditingController not disposed. (flutter/flutter#136615)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
Roll Flutter from afc3916 to 6eea6e2 (27 revisions) (#5165)
14aa69e 
flutter/flutter@afc3916...6eea6e2

2023-10-17 hans.muller@gmail.com Removed TBD translations for optional remainingTextFieldCharacterCounZero message (flutter/flutter#136684)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 86f685c87e06 to 0a4d8b99a95b (2 revisions) (flutter/flutter#136727)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (flutter/flutter#136725)
2023-10-17 engine-flutter-autoroll@skia.org Roll Packages from 872d6d2 to d439062 (4 revisions) (flutter/flutter#136724)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c744ad5433a to 793fb7d85690 (1 revision) (flutter/flutter#136721)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d47532bb56f to 9c744ad5433a (1 revision) (flutter/flutter#136719)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ace31a8eaea4 to 7d47532bb56f (1 revision) (flutter/flutter#136717)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 077494a09872 to ace31a8eaea4 (1 revision) (flutter/flutter#136713)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8be0b5398d41 to 077494a09872 (1 revision) (flutter/flutter#136712)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90bbe8ee4ac3 to 8be0b5398d41 (1 revision) (flutter/flutter#136705)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6855e78a1aac to 90bbe8ee4ac3 (1 revision) (flutter/flutter#136700)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2159fdb8461d to 6855e78a1aac (1 revision) (flutter/flutter#136697)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d55e29dfa79 to 2159fdb8461d (8 revisions) (flutter/flutter#136695)
2023-10-17 tvolkert@users.noreply.github.com Add docs to SchedulerBinding (flutter/flutter#136433)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 83224dcd662e to 2d55e29dfa79 (3 revisions) (flutter/flutter#136675)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c24f30343cf6 to 83224dcd662e (1 revision) (flutter/flutter#136671)
2023-10-16 dnfield@google.com Do not hold on to stale canvas reference in _RenderSegmentedButton (flutter/flutter#136658)
2023-10-16 dnfield@google.com Avoid use of Platform.script in isolates_test.dart (flutter/flutter#136669)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca8cf6bc256d to c24f30343cf6 (3 revisions) (flutter/flutter#136665)
2023-10-16 christopherfujino@gmail.com update analytics in generate api docs site to use new UA4 (flutter/flutter#136497)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64734a266683 to ca8cf6bc256d (2 revisions) (flutter/flutter#136662)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 850de4ce0e75 to 64734a266683 (2 revisions) (flutter/flutter#136659)
2023-10-16 goderbauer@google.com Fix prefer_mixin TODOs (flutter/flutter#136480)
2023-10-16 41873024+droidbg@users.noreply.github.com Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed.  (flutter/flutter#136615)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6cc678c528d1 to 850de4ce0e75 (1 revision) (flutter/flutter#136650)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 505c720fd10f to 6cc678c528d1 (1 revision) (flutter/flutter#136646)
2023-10-16 engine-flutter-autoroll@skia.org Roll Packages from fd84e65 to 872d6d2 (5 revisions) (flutter/flutter#136644)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Oct 20, 2023
Open
@droidbg droidbg deleted the cupertino-search-field-tracking branch November 13, 2023 01:43
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from afc3916 to 6eea6e2 (27 revisions) (flutter#5165)
ab2fabb 
flutter/flutter@afc3916...6eea6e2

2023-10-17 hans.muller@gmail.com Removed TBD translations for optional remainingTextFieldCharacterCounZero message (flutter/flutter#136684)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 86f685c87e06 to 0a4d8b99a95b (2 revisions) (flutter/flutter#136727)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (flutter/flutter#136725)
2023-10-17 engine-flutter-autoroll@skia.org Roll Packages from 872d6d2 to d439062 (4 revisions) (flutter/flutter#136724)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c744ad5433a to 793fb7d85690 (1 revision) (flutter/flutter#136721)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d47532bb56f to 9c744ad5433a (1 revision) (flutter/flutter#136719)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ace31a8eaea4 to 7d47532bb56f (1 revision) (flutter/flutter#136717)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 077494a09872 to ace31a8eaea4 (1 revision) (flutter/flutter#136713)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8be0b5398d41 to 077494a09872 (1 revision) (flutter/flutter#136712)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 90bbe8ee4ac3 to 8be0b5398d41 (1 revision) (flutter/flutter#136705)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6855e78a1aac to 90bbe8ee4ac3 (1 revision) (flutter/flutter#136700)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2159fdb8461d to 6855e78a1aac (1 revision) (flutter/flutter#136697)
2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d55e29dfa79 to 2159fdb8461d (8 revisions) (flutter/flutter#136695)
2023-10-17 tvolkert@users.noreply.github.com Add docs to SchedulerBinding (flutter/flutter#136433)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 83224dcd662e to 2d55e29dfa79 (3 revisions) (flutter/flutter#136675)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from c24f30343cf6 to 83224dcd662e (1 revision) (flutter/flutter#136671)
2023-10-16 dnfield@google.com Do not hold on to stale canvas reference in _RenderSegmentedButton (flutter/flutter#136658)
2023-10-16 dnfield@google.com Avoid use of Platform.script in isolates_test.dart (flutter/flutter#136669)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca8cf6bc256d to c24f30343cf6 (3 revisions) (flutter/flutter#136665)
2023-10-16 christopherfujino@gmail.com update analytics in generate api docs site to use new UA4 (flutter/flutter#136497)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64734a266683 to ca8cf6bc256d (2 revisions) (flutter/flutter#136662)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 850de4ce0e75 to 64734a266683 (2 revisions) (flutter/flutter#136659)
2023-10-16 goderbauer@google.com Fix prefer_mixin TODOs (flutter/flutter#136480)
2023-10-16 41873024+droidbg@users.noreply.github.com Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed.  (flutter/flutter#136615)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6cc678c528d1 to 850de4ce0e75 (1 revision) (flutter/flutter#136650)
2023-10-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 505c720fd10f to 6cc678c528d1 (1 revision) (flutter/flutter#136646)
2023-10-16 engine-flutter-autoroll@skia.org Roll Packages from fd84e65 to 872d6d2 (5 revisions) (flutter/flutter#136644)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c changed the title Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed. Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed. [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droidbg @polina-c