Use Xcode build setting PRODUCT_NAME to find app and archive paths

[jmagman]

1. Instead of getting the FULL_PRODUCT_NAME Xcode build setting (Runner.app) instead use PRODUCT_NAME since most places really want the product name, and the extension stripping wasn't correct when the name contained periods.
2. Don't instruct the user to open the xcarchive in Xcode if it doesn't exist.

Fixes #140212

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[jmagman]

I still need to track down the test failures.

00:19 +1667 ~3 -1: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode fails when Xcode workspace is not found [E]                          
  Expected: contains 'Unable to get Xcode workspace'
    Actual: 'Could not find the built application bundle at build/ios/iphoneos/My Super Awesome App.app.app.\n'
              ''
     Which: does not contain 'Unable to get Xcode workspace'
  
  package:matcher                                                      expect
  test/general.shard/ios/ios_device_start_nonprebuilt_test.dart 754:9  main.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  test/src/context.dart 141:26                                         testUsingContext.<fn>.<fn>.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  test/src/context.dart 102:5        

00:20 +1891 ~3 -2: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode succeeds [E]                                                         

00:22 +2043 ~3 -3: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode with flavor succeeds [E]  

[jmagman]

I still need to track down the test failures.

00:19 +1667 ~3 -1: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode fails when Xcode workspace is not found [E]                          
  Expected: contains 'Unable to get Xcode workspace'
    Actual: 'Could not find the built application bundle at build/ios/iphoneos/My Super Awesome App.app.app.\n'
              ''
     Which: does not contain 'Unable to get Xcode workspace'
  
  package:matcher                                                      expect
  test/general.shard/ios/ios_device_start_nonprebuilt_test.dart 754:9  main.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  test/src/context.dart 141:26                                         testUsingContext.<fn>.<fn>.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 153:19                   AppContext.run.<fn>
  ===== asynchronous gap ===========================
  test/src/context.dart 102:5        

00:20 +1891 ~3 -2: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode succeeds [E]                                                         

00:22 +2043 ~3 -3: test/general.shard/ios/ios_device_start_nonprebuilt_test.dart: IOSDevice.startApp for CoreDevice in debug mode with flavor succeeds [E]  

Still haven't had a chance to look at this.

[jmagman]

Still haven't had a chance to look at this, let's see if I get to it before critical triage messages me again!

[LouiseHsu]

LGTM!

[LouiseHsu]

minuscule nit: the old error msg is Try distributing the app in Xcode: "open $absoluteArchivePath", but the new one would be Try distributing the app in Xcode: open $absoluteArchivePath
not sure if thats intended?

[jmagman]

I think the quotes in the old one are because it's on the same line, so the quotes delineate the instructions vs the command to run. The new one will print it on a newline with indentation, which matches a few other spots, (though the tool is pretty inconsistent):

flutter/packages/flutter_tools/lib/src/ios/mac.dart

Lines 203 to 204 in 8e6643c

	globals.printError('Open Xcode to fix the problem:');
	globals.printError(' open ios/Runner.xcworkspace');

flutter/packages/flutter_tools/lib/src/ios/devices.dart

Lines 424 to 425 in 8e6643c

	_logger.printError('Try launching Xcode and selecting "Product > Run" to fix the problem:');
	_logger.printError(' open ios/Runner.xcworkspace');

Though, come to think of it, the logger has an indent parameter I can use. I'll update.