-
Notifications
You must be signed in to change notification settings - Fork 167
Renaming Runner
to a name containing a .
causes shorebird release ios
to fail
#2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This appears to be an issue with upstream Flutter. Renaming
|
I suspect this is the bug: https://github.com/flutter/flutter/blob/f634098b3ed553e6fe35cca4ef0de282e6176b1e/packages/flutter_tools/lib/src/ios/application_package.dart#L144 Which appears to be calling: Hmm, but that shouldn't be the problem:
|
Makes me think that the rename might not have been complete? |
Like Bryan mentioned, this seems to be broken upstream, when trying to build an iOS project that have names with dots, the flutter tool crashes. There is an issue open upstream: flutter/flutter#140212 |
This will just fix itself when the upstream issue is fixed, so I think we can close this. |
Hello |
Since this issue comes from upstream, i don't think there is much workarounds that we could do unfortunately |
@bryanoltman I merged an upstream fix flutter/flutter#140242, want to give it a try again on the Flutter master branch? |
@bryanoltman when we can try it with shorebird? |
We could potentially try cherry-picking flutter/flutter@f33ffc0 into shorebirdtech/flutter |
It cherry-picks cleanly. We just need to get the flutter_tools tests passing cleanly before we do so: #2392 |
To reproduce:
.
(ex:My.Runner
)shorebird release ios
The text was updated successfully, but these errors were encountered: