-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding better logging on iOS build command when generate shorebird file is not found. #57
feat: adding better logging on iOS build command when generate shorebird file is not found. #57
Conversation
…ird file is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, do we need a test?
I would love to add a test for this, but unfortunately I still am not able to reproduce the issue. I am hopping that with this log, we might be able to get better information. |
// The max depth is just a hard limit to prevent the cli from going to far behind. | ||
// This limit should never be reached though, since at least the `Applications` or | ||
// `Products` folder should exist, no matter what changed in the app. | ||
const int maxDepth = 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have the max depth at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be too overcautious here, but I was worried that we end up recurring back too much and end in a user "personal" folder and kind trigger the user that we are invading their files.
This depth makes sure that we don't go past the build folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment should probably say that then. :)
Example of output:
|
A few issues are reporting a similar error:
Exception: Cannot find shorebird.yaml
Runner
to a name containing a.
causesshorebird release ios
to fail shorebird#2206That log doesn't tell us much though. This PR doesn't solve that issue, but adds better logging when this is happens so we can try troubleshoot this better.