Skip to content

Commit

Permalink
[url_launcher_android] Set buildFeatures.buildConfig to true for co…
Browse files Browse the repository at this point in the history
…mpatibility with AGP 8.0+ (#4535)

This flag controls the generation of the BuildConfig class, which is [used to guard a log line](https://github.com/flutter/packages/blob/05fdd1337f3f9e2335144f4fe20e839743f4efa1/packages/url_launcher/url_launcher_android/android/src/main/java/io/flutter/plugins/urllauncher/UrlLauncher.java#L66).

In AGP 7.x this flag [defaulted to true](https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BuildFeatures#buildConfig:kotlin.Boolean). AGP 8.x [changed it to default to false](https://developer.android.com/reference/tools/gradle-api/8.0/com/android/build/api/dsl/BuildFeatures#buildConfig()). This PR sets it explicitly to true, so we don't rely on defaults, and fixes an error for people using AGP 8.0+. I also upgraded an old AGP version while I was at it.

Fixes flutter/flutter#128204.
  • Loading branch information
gmackall authored Jul 20, 2023
1 parent a9731f2 commit 896131f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.0.37

* Sets android.defaults.buildfeatures.buildconfig to true for compatibility with AGP 8.0+.

## 6.0.36

* Bumps androidx.annotation:annotation from 1.2.0 to 1.6.0.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:4.2.0'
classpath 'com.android.tools.build:gradle:7.3.0'
}
}

Expand All @@ -22,6 +22,9 @@ rootProject.allprojects {
apply plugin: 'com.android.library'

android {
buildFeatures {
buildConfig true
}
// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace 'io.flutter.plugins.urllauncher'
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_android
description: Android implementation of the url_launcher plugin.
repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.36
version: 6.0.37

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down

0 comments on commit 896131f

Please sign in to comment.