Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url_launcher_android] Set buildFeatures.buildConfig to true for compatibility with AGP 8.0+ #4535

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[url_launcher_android] Set buildFeatures.buildConfig to true for compatibility with AGP 8.0+ #4535

merged 3 commits into from
Jul 20, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jul 20, 2023 •
edited
Loading

This flag controls the generation of the BuildConfig class, which is used to guard a log line.

In AGP 7.x this flag defaulted to true. AGP 8.x changed it to default to false. This PR sets it explicitly to true, so we don't rely on defaults, and fixes an error for people using AGP 8.0+. I also upgraded an old AGP version while I was at it.

Fixes flutter/flutter#128204.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmackall gmackall requested a review from stuartmorgan July 20, 2023 21:32
stuartmorgan
stuartmorgan approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Jul 20, 2023

test-exempt: We can't test this until we have the right version of Java in CI; the plan is to look into rolling all our examples forward to 8 once we migrate Android tests to LUCI, since it should hopefully be easier to manage our Java version at that point.

@Hixie Hixie mentioned this pull request Jul 20, 2023
Closed
11 tasks
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2023
@auto-submit auto-submit bot merged commit 896131f into flutter:main Jul 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
896131f [url_launcher_android] Set buildFeatures.buildConfig to tru…
731ef3f 
…e for compatibility with AGP 8.0+ (flutter/packages#4535)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
Roll Packages from 674179f to 2266a76 (6 revisions) (#131058)
9cfbf6b 
flutter/packages@674179f...2266a76

2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525)
2023-07-20 34871572+gmackall@users.noreply.github.com [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535)
2023-07-20 59682979+utamori@users.noreply.github.com [go_router] fix error handling page link (flutter/packages#4296)
2023-07-20 stuartmorgan@google.com [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534)
2023-07-20 stuartmorgan@google.com [ci] Simplify Dockerfile (flutter/packages#4530)
2023-07-20 stuartmorgan@google.com [ci] Enable Windows Dart unit test sharding (flutter/packages#4528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 674179f to 2266a76 (6 revisions) (flutter#131058)
f00e80f 
flutter/packages@674179f...2266a76

2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525)
2023-07-20 34871572+gmackall@users.noreply.github.com [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535)
2023-07-20 59682979+utamori@users.noreply.github.com [go_router] fix error handling page link (flutter/packages#4296)
2023-07-20 stuartmorgan@google.com [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534)
2023-07-20 stuartmorgan@google.com [ci] Simplify Dockerfile (flutter/packages#4530)
2023-07-20 stuartmorgan@google.com [ci] Enable Windows Dart unit test sharding (flutter/packages#4528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
@gmackall gmackall mentioned this pull request Sep 19, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 25, 2023
@gmackall
[camera_android] Set buildconfig to true for compatibility with AGP 8…
4e2cc50 
….0+ (#4951)

Fixes flutter/flutter#134818

See #4535 for an example of when this was done for a different plugin.
@huycozy huycozy mentioned this pull request Dec 4, 2023
Closed
2 tasks
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@gmackall @HugoOlthof
[camera_android] Set buildconfig to true for compatibility with AGP 8…
eee51a0 
….0+ (flutter#4951)

Fixes flutter/flutter#134818

See flutter#4535 for an example of when this was done for a different plugin.
@gmackall gmackall mentioned this pull request Apr 4, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[url_launcher][Android] Cannot find symbol BuildConfig on AGP 8.0+
3 participants
@gmackall @Hixie @stuartmorgan