Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url_launcher_android] Set buildFeatures.buildConfig to true for compatibility with AGP 8.0+ #4535

Merged
merged 3 commits into from
Jul 20, 2023
Merged

[url_launcher_android] Set buildFeatures.buildConfig to true for compatibility with AGP 8.0+ #4535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee90569
enable buildConfig explicitly in url_launch_android build.gradle
Jul 20, 2023
31cd9ef
Merge branch 'flutter:main' into url_launcher_agp8
gmackall Jul 20, 2023
a955572
pubspec and version changes
Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.0.37

* Sets android.defaults.buildfeatures.buildconfig to true for compatibility with AGP 8.0+.

## 6.0.36

* Bumps androidx.annotation:annotation from 1.2.0 to 1.6.0.
Expand Down
5 changes: 4 additions & 1 deletion packages/url_launcher/url_launcher_android/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:4.2.0'
classpath 'com.android.tools.build:gradle:7.3.0'
}
}

Expand All @@ -22,6 +22,9 @@ rootProject.allprojects {
apply plugin: 'com.android.library'

android {
buildFeatures {
buildConfig true
}
// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace 'io.flutter.plugins.urllauncher'
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_android
description: Android implementation of the url_launcher plugin.
repository: https://github.com/flutter/packages/tree/main/packages/url_launcher/url_launcher_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.36
version: 6.0.37

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down