Skip to content

Function(ImageInfo, bool) --> ImageStreamListener #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Function(ImageInfo, bool) --> ImageStreamListener #22

wants to merge 1 commit into from

Conversation

2534290808
Copy link

fix void Function(ImageInfo, bool) can't be assigned to the ImageStreamListener

fix void Function(ImageInfo, bool) can't be assigned to the ImageStreamListener
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adrianvintu
Copy link

Please let us know on the status of this.

@andreidiaconu
Copy link

andreidiaconu commented Jul 17, 2019

@2534290808 From what I can see, this will not move forward for 2 reasons:

  • The CLA needs to be signed, as googlebot mentioned
  • The issues raised by analyze need to be fixed:
  info - Specify type annotations at lib/palette_generator.dart:282:35 - (always_specify_types)
  info - Set literals were not supported until version 2.2, but this code is required to be able to run on earlier versions at lib/palette_generator.dart:282:35 - (sdk_version_set_literal)
  info - Prefer const with constant constructors at test/palette_generator_test.dart:105:19 - (prefer_const_constructors)
  info - Prefer const with constant constructors at test/palette_generator_test.dart:115:14 - (prefer_const_constructors)
  info - Prefer const with constant constructors at test/palette_generator_test.dart:122:14 - (prefer_const_constructors)

If you need help with the second point, let us know. If you don't agree with the CLA, also let us know, so we can open a separate PR that can be merged. Thank you for getting back to us.

@adrianvintu if you need a workaround for now, you can consider forking the patch fork :) or using it directly in your pubspec:

  palette_generator:
    git:
      url: git://github.com/2534290808/packages.git
      path: packages/palette_generator
      ref: 80a547345bd91d8ee7d747ea250d12fa0094d64c #or just patch-1

@adrianvintu
Copy link

@andreidiaconu holy shmoly Andrei, thank you for the cool workaround.

Wish you all the best!

@tvolkert
Copy link
Contributor

This is also fixed in #24, which contains the analysis error fixes and a version bump as well, so I'm going to close this PR in favor of that one.

Sorry for the dup - I only saw this PR after I sent the other one!

@tvolkert tvolkert closed this Jul 19, 2019
@tvolkert
Copy link
Contributor

Ok, #24 is merged. I don't have permission to upload a new version of the package. @gspencergoog can you add me as an uploader and/or publish a new version?

@gspencergoog
Copy link
Contributor

gspencergoog commented Jul 19, 2019

I added you as an uploader, @tvolkert, and I also published a new version.

stuartmorgan-g pushed a commit to stuartmorgan-g/packages that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants