Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to work on latest Flutter #24

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Update code to work on latest Flutter #24

merged 4 commits into from
Jul 19, 2019

Conversation

tvolkert
Copy link
Contributor

No description provided.

@tvolkert tvolkert requested a review from stuartmorgan July 19, 2019 04:56
@tvolkert
Copy link
Contributor Author

Fixes flutter/flutter#36456

@tvolkert tvolkert mentioned this pull request Jul 19, 2019
Closed
stuartmorgan
stuartmorgan approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't this need a version bump? (I'm not clear whether it would be 0.1.2 or 0.2.0 given that it's for a breaking change.)

@tvolkert
Copy link
Contributor Author

Yep. Bumped it to 0.2.0, which is the right pre-1.0 breaking change bump.

@tvolkert tvolkert mentioned this pull request Jul 19, 2019
Closed
@tvolkert tvolkert merged commit bc85a0b into flutter:master Jul 19, 2019
@tvolkert tvolkert deleted the update branch July 19, 2019 06:08
gspencergoog pushed a commit to gspencergoog/packages that referenced this pull request Aug 19, 2020
@dotdoom @yjbanov
Bump upper bound of 'mockito' dependency (flutter#24)
856e6f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvolkert @stuartmorgan