Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle with a comment explaining version #3972

Merged
merged 3 commits into from
May 12, 2023
Merged

Update build.gradle with a comment explaining version #3972

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50789bb
Update build.gradle with a comment explaining version
reidbaker May 12, 2023
d9c2fc4
Apply suggestions from code review
reidbaker May 12, 2023
ad8536c
Merge branch 'main' into kotlin-doc-update-bom-1
reidbaker May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/camera/camera_android_camerax/example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
buildscript {
// This version should intentionally be a 1.7.* verson and lower than the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe and "lower than the version of kotlin-bom..."? Some might get confused that this is a version of kotlin gradle plugin, and go look for a version of kotlin gradle plugin in packages/camera/camera_android_camerax/android/build.gradle, but not find one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// version defined in packages/camera/camera_android_camerax/android/build.gradle.
// This tests that the kotlin version resolution continues to work.
ext.kotlin_version = '1.7.10'
repositories {
google()
Expand Down