Update build.gradle with a comment explaining version #3972

reidbaker · 2023-05-12T16:29:08Z

Followup to https://github.com/flutter/packages/pull/3960/files/eda00fe0ee329433a013b63a1b7727f90f2d0de2#r1192563559

Pre-launch Checklist

flutter-dashboard · 2023-05-12T16:29:10Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gmackall · 2023-05-12T16:33:08Z

packages/camera/camera_android_camerax/example/android/build.gradle

@@ -1,4 +1,7 @@
 buildscript {
+    // This version should intentionally be a 1.7.* verson and lower than the 


Maybe and "lower than the version of kotlin-bom..."? Some might get confused that this is a version of kotlin gradle plugin, and go look for a version of kotlin gradle plugin in packages/camera/camera_android_camerax/android/build.gradle, but not find one.

packages/camera/camera_android_camerax/example/android/build.gradle

gmackall

LGTM!

Hixie · 2023-05-12T20:46:49Z

test-exempt: only affects comments

(bonus points available for teaching the bot about gradle comment syntax; it already knows about Dart comments being automatically test exempt)

gmackall · 2023-05-12T21:02:14Z

test-exempt: only affects comments

(bonus points available for teaching the bot about gradle comment syntax; it already knows about Dart comments being automatically test exempt)

I was curious how the parsing worked so I took a quick look and it looks like it should be as simple as adding gradle to the list of recognized extensions, because the single line comment syntax is the same as java/the others we are parsing (and single line comment are all we seem to support anyways).

…r/packages#3972)

flutter/packages@6328cfb...6608b60 2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Followup to https://github.com/flutter/packages/pull/3960/files/eda00fe0ee329433a013b63a1b7727f90f2d0de2#r1192563559 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.

Update build.gradle with a comment explaining version

50789bb

reidbaker requested a review from camsim99 as a code owner May 12, 2023 16:29

flutter-dashboard bot added the needs tests label May 12, 2023

reidbaker requested a review from gmackall May 12, 2023 16:29

github-actions bot added p: camera platform-android labels May 12, 2023

gmackall reviewed May 12, 2023

View reviewed changes

reidbaker commented May 12, 2023

View reviewed changes

packages/camera/camera_android_camerax/example/android/build.gradle Outdated Show resolved Hide resolved

reidbaker commented May 12, 2023

View reviewed changes

packages/camera/camera_android_camerax/example/android/build.gradle Outdated Show resolved Hide resolved

Apply suggestions from code review

d9c2fc4

reidbaker requested a review from gmackall May 12, 2023 19:48

reidbaker marked this pull request as draft May 12, 2023 19:49

reidbaker marked this pull request as ready for review May 12, 2023 19:49

gmackall approved these changes May 12, 2023

View reviewed changes

camsim99 approved these changes May 12, 2023

View reviewed changes

Merge branch 'main' into kotlin-doc-update-bom-1

ad8536c

reidbaker merged commit 837853e into main May 12, 2023

reidbaker deleted the kotlin-doc-update-bom-1 branch May 12, 2023 20:56

reidbaker mentioned this pull request May 15, 2023

[cocoon] Make text exempt bot understand gradle comments flutter/flutter#126825

Closed

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

837853e Update build.gradle with a comment explaining version (flutte…

8a56c94

…r/packages#3972)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

837853e Update build.gradle with a comment explaining version (flutte…

1f74d61

…r/packages#3972)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) flutter/flutter#126865

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

837853e Update build.gradle with a comment explaining version (flutte…

392e0c4

…r/packages#3972)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update build.gradle with a comment explaining version #3972

Update build.gradle with a comment explaining version #3972

reidbaker commented May 12, 2023

flutter-dashboard bot commented May 12, 2023

gmackall May 12, 2023

reidbaker May 12, 2023

gmackall left a comment

Hixie commented May 12, 2023

gmackall commented May 12, 2023

		@@ -1,4 +1,7 @@
		buildscript {
		// This version should intentionally be a 1.7.* verson and lower than the

Update build.gradle with a comment explaining version #3972

Update build.gradle with a comment explaining version #3972

Conversation

reidbaker commented May 12, 2023

Pre-launch Checklist

flutter-dashboard bot commented May 12, 2023

gmackall May 12, 2023

Choose a reason for hiding this comment

reidbaker May 12, 2023

Choose a reason for hiding this comment

gmackall left a comment

Choose a reason for hiding this comment

Hixie commented May 12, 2023

gmackall commented May 12, 2023