[ci] Enforce a minimum Kotlin version in examples #3979

stuartmorgan · 2023-05-13T18:06:05Z

#3973 caused an out-of-band failure after publishing, because an example that uses url_launcher had a too-old Kotlin version set. This is not something we consider client-breaking because flutter prodives a very clear error message with a straightforward and actionable fix step (update the app's Kotlin version), so the fix for the breakage is just to update our own examples.

Since increasingly we're likely to hit problems where modern version of dependencies don't work with old version of Kotlin, this adds repo-wide CI enforcement that examples are set to a minimum version (matching the current flutter/flutter template; we can increase this over time as we feel it's useful to do so).

stuartmorgan · 2023-05-13T18:07:07Z

CODEOWNERs forced a bunch of reviewers on this; @reidbaker is the only one who needs to actually review, since he should weigh in on this as something we should in fact enforce.

domesticmouse

To keep codeowners happy

tarrinneal · 2023-05-15T14:14:53Z

script/tool/test/gradle_check_command_test.dart

+        output,
+        containsAllInOrder(<Matcher>[
+          contains('build.gradle sets "ext.kotlin_version" to "1.6.21". The '
+              'minimum Kotlin version that can be specified is 1.7.10, for '


This test will need to be updated every time the minimum changes, correct? Is that ideal? (This also applies to the "same as" test)

I agree I think both should use a modified minKotlinVersion that is @visibleForTesting

Good point; done.

stuartmorgan · 2023-05-15T14:53:59Z

Landing on red to fix the tree.

…ckages#3979)

flutter/packages@6328cfb...6608b60 2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#3973 caused an out-of-band failure after publishing, because an example that uses `url_launcher` had a too-old Kotlin version set. This is not something we consider client-breaking because `flutter` prodives a very clear error message with a straightforward and actionable fix step (update the app's Kotlin version), so the fix for the breakage is just to update our own examples. Since increasingly we're likely to hit problems where modern version of dependencies don't work with old version of Kotlin, this adds repo-wide CI enforcement that examples are set to a minimum version (matching the current `flutter/flutter` template; we can increase this over time as we feel it's useful to do so).

stuartmorgan added 2 commits May 13, 2023 13:53

Add tooling check

31bb29e

Fix violations

0747f43

stuartmorgan requested review from reidbaker, tarrinneal, Hixie, chunhtai, domesticmouse, Piinks and goderbauer as code owners May 13, 2023 18:06

github-actions bot added p: animations p: dynamic_layouts The dynamic_layouts package p: flutter_markdown p: go_router p: rfw Remote Flutter Widgets p: shared_preferences platform-android labels May 13, 2023

Analysis fix

5c86692

domesticmouse approved these changes May 13, 2023

View reviewed changes

reidbaker approved these changes May 15, 2023

View reviewed changes

tarrinneal reviewed May 15, 2023

View reviewed changes

Use a variable for tests

4123b57

stuartmorgan merged commit 8febbba into flutter:main May 15, 2023

stuartmorgan deleted the min-example-kotlin-version branch May 15, 2023 14:55

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

8febbba [ci] Enforce a minimum Kotlin version in examples (flutter/pa…

d69106f

…ckages#3979)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

8febbba [ci] Enforce a minimum Kotlin version in examples (flutter/pa…

d67651e

…ckages#3979)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) flutter/flutter#126865

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

8febbba [ci] Enforce a minimum Kotlin version in examples (flutter/pa…

b2a6c0f

…ckages#3979)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] Enforce a minimum Kotlin version in examples #3979

[ci] Enforce a minimum Kotlin version in examples #3979

stuartmorgan commented May 13, 2023

stuartmorgan commented May 13, 2023 •

edited

Loading

domesticmouse left a comment

tarrinneal May 15, 2023

reidbaker May 15, 2023

stuartmorgan May 15, 2023

stuartmorgan commented May 15, 2023

[ci] Enforce a minimum Kotlin version in examples #3979

[ci] Enforce a minimum Kotlin version in examples #3979

Conversation

stuartmorgan commented May 13, 2023

stuartmorgan commented May 13, 2023 • edited Loading

domesticmouse left a comment

Choose a reason for hiding this comment

tarrinneal May 15, 2023

Choose a reason for hiding this comment

reidbaker May 15, 2023

Choose a reason for hiding this comment

stuartmorgan May 15, 2023

Choose a reason for hiding this comment

stuartmorgan commented May 15, 2023

stuartmorgan commented May 13, 2023 •

edited

Loading