[camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib #3960

gmackall · 2023-05-10T17:49:33Z

A fresh sample app that adds a dependency on the camerax implementation of the camera plugin will fail to build with an error about duplicate classes*. This PR adds a dependency on kotlin-bom to align versions of kotlin transitive dependencies that are used.

The idea for the fix comes from here, which has some more discussion about the problem (but in a different context, unrelated to flutter).

* The error looks like this:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30)
     Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10)
...

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-05-10T17:49:35Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

camsim99

LGTM with a version bump :)

gmackall · 2023-05-10T17:56:21Z

LGTM with a version bump :)

Yep, I think yours will land first so 0.5.0+2?

camsim99 · 2023-05-10T18:02:22Z

LGTM with a version bump :)

Yep, I think yours will land first so 0.5.0+2?

Yes!

stuartmorgan · 2023-05-10T18:45:59Z

LGTM with a version bump :)

Yep, I think yours will land first so 0.5.0+2?

Yes!

We should also remove the README change in this PR since it won't apply any more.

…ld be fixed

gmackall · 2023-05-10T18:53:17Z

We should also remove the README change in this PR since it won't apply any more.

I removed the note and also the section as there was nothing left, let me know if you think it would be better to have the section remain but be empty for now!

…ate class issue was removed

stuartmorgan · 2023-05-10T19:44:02Z

packages/camera/camera_android_camerax/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.5.0+2
+
+* Add a dependency on kotlin-bom to align versions kotlin transitive dependencies.


Nit: Adds

https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style

stuartmorgan · 2023-05-10T19:44:10Z

packages/camera/camera_android_camerax/CHANGELOG.md

+## 0.5.0+2
+
+* Add a dependency on kotlin-bom to align versions kotlin transitive dependencies.
+* Remove note in `README.md` regarding duplicate Kotlin classes issue.


stuartmorgan · 2023-05-10T19:44:38Z

packages/camera/camera_android_camerax/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.5.0+2
+
+* Add a dependency on kotlin-bom to align versions kotlin transitive dependencies.


Is this missing an "of" in "versions kotlin"?

(also, "Kotlin")

Yes it is 🤦. It was originally "to align Kotlin transitive dependencies" and I missed an "of" when adding "versions"

stuartmorgan · 2023-05-10T19:45:04Z

I removed the note and also the section as there was nothing left

👍🏻

gmackall · 2023-05-10T20:37:06Z

Manually removing the needs-tests label per advice on discord from @stuartmorgan that this is in fact being tested due to the change to use Kotlin 1.7.10 in the example app.

reidbaker · 2023-05-12T16:15:20Z

packages/camera/camera_android_camerax/example/android/build.gradle

@@ -1,5 +1,5 @@
 buildscript {
-    ext.kotlin_version = '1.8.0'
+    ext.kotlin_version = '1.7.10'


Why does this have version 1.7.10 but the code here packages/camera/camera_android_camerax/android/build.gradle
Has 1.8.10?

We explicitly want to test that the plugin works out of the box for users with a default flutter create setup, which still uses 1.7.10. Otherwise anyone using this plugin gets confusing compile errors and has to change their app settings.

… kotlin-stdlib (flutter/packages#3960)

flutter/packages@6328cfb...6608b60 2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…stdlib (flutter#3960) A fresh sample app that adds a dependency on the camerax implementation of the camera plugin will fail to build with an error about duplicate classes*. This PR adds a dependency on kotlin-bom to align versions of kotlin transitive dependencies that are used. The idea for the fix comes [from here](https://youtrack.jetbrains.com/issue/KT-55297/kotlin-stdlib-should-declare-constraints-on-kotlin-stdlib-jdk8-and-kotlin-stdlib-jdk7), which has some more discussion about the problem (but in a different context, unrelated to flutter). \* The error looks like this: ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':app:checkDebugDuplicateClasses'. > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable > Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk8-1.5.30 (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30) Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations found in modules jetified-kotlin-stdlib-1.8.10 (org.jetbrains.kotlin:kotlin-stdlib:1.8.10) and jetified-kotlin-stdlib-jdk7-1.7.10 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10) ... ```

aligning kotlin version

9220ea3

gmackall requested a review from camsim99 as a code owner May 10, 2023 17:49

flutter-dashboard bot added the needs tests label May 10, 2023

github-actions bot added p: camera platform-android labels May 10, 2023

camsim99 approved these changes May 10, 2023

View reviewed changes

gmackall and others added 2 commits May 10, 2023 10:58

Merge branch 'main' into kotlin_version_fix

8fb2f71

adding changelog/pubspec for kotlin version fix changes

86b48b2

gmackall requested a review from stuartmorgan May 10, 2023 18:02

Gray Mackall added 2 commits May 10, 2023 11:48

changing kotlin version to 1.7.10 in example app

f1696d9

removing readme note about duplicate class issue, as the problem shou…

26f1c72

…ld be fixed

updating CHANGELOG to also note that the README section on the duplic…

169f828

…ate class issue was removed

stuartmorgan reviewed May 10, 2023

View reviewed changes

fixing typos/style issues in CHANGELOG

eda00fe

gmackall requested a review from reidbaker May 10, 2023 20:33

gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels May 10, 2023

auto-submit bot merged commit 58618c9 into flutter:main May 12, 2023

reidbaker reviewed May 12, 2023

View reviewed changes

reidbaker mentioned this pull request May 12, 2023

[url_launcher] Set broadcast reciever visability as required by target api 34 #3973

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

58618c9 [camerax] Add a dependency on kotlin-bom to align versions of…

1796c34

… kotlin-stdlib (flutter/packages#3960)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

58618c9 [camerax] Add a dependency on kotlin-bom to align versions of…

aaf4e64

… kotlin-stdlib (flutter/packages#3960)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) flutter/flutter#126865

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

58618c9 [camerax] Add a dependency on kotlin-bom to align versions of…

adb8888

… kotlin-stdlib (flutter/packages#3960)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

stuartmorgan mentioned this pull request Jul 9, 2024

[many] Remove dependency on kotlin-bom #7088

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib #3960

[camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib #3960

gmackall commented May 10, 2023 •

edited

Loading

flutter-dashboard bot commented May 10, 2023

camsim99 left a comment

gmackall commented May 10, 2023

camsim99 commented May 10, 2023

stuartmorgan commented May 10, 2023

gmackall commented May 10, 2023

stuartmorgan May 10, 2023

stuartmorgan May 10, 2023

stuartmorgan May 10, 2023

gmackall May 10, 2023

stuartmorgan commented May 10, 2023

gmackall commented May 10, 2023

reidbaker May 12, 2023

stuartmorgan May 12, 2023

		@@ -1,3 +1,8 @@
		## 0.5.0+2

		* Add a dependency on kotlin-bom to align versions kotlin transitive dependencies.

[camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib #3960

[camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib #3960

Conversation

gmackall commented May 10, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented May 10, 2023

camsim99 left a comment

Choose a reason for hiding this comment

gmackall commented May 10, 2023

camsim99 commented May 10, 2023

stuartmorgan commented May 10, 2023

gmackall commented May 10, 2023

stuartmorgan May 10, 2023

Choose a reason for hiding this comment

stuartmorgan May 10, 2023

Choose a reason for hiding this comment

stuartmorgan May 10, 2023

Choose a reason for hiding this comment

gmackall May 10, 2023

Choose a reason for hiding this comment

stuartmorgan commented May 10, 2023

gmackall commented May 10, 2023

reidbaker May 12, 2023

Choose a reason for hiding this comment

stuartmorgan May 12, 2023

Choose a reason for hiding this comment

gmackall commented May 10, 2023 •

edited

Loading