Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router] Adds on exit #4699

Merged
merged 5 commits into from
Sep 18, 2023
Merged

[go_router] Adds on exit #4699

merged 5 commits into from
Sep 18, 2023

Conversation

chunhtai
Copy link
Contributor

related flutter/flutter#102408

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from hannah-hyj August 14, 2023 22:25
@chunhtai
Copy link
Contributor Author

cc @GP4cK

navaronbracke
navaronbracke reviewed Aug 16, 2023
View reviewed changes
packages/go_router/lib/src/route.dart
///
/// If the return value is true or the future resolve to true, the route will
/// exit as usual. Otherwise, the operation will abort.
typedef ExitCallback = FutureOr<bool> Function(BuildContext context);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Future<bool> instead? Using FutureOr<T> is discouraged iirc.

I get the intent, but a user can always do onExit: (BuildContext context) async => false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will like to provide a chance to handle this synchronously. Otherwise it would introduce one frame delay between navigation. Also the ship has sailed for GoRoute.redirect, so I will keep this as is.

@MendleM
Copy link

MendleM commented Sep 12, 2023

@chunhtai Any major blockers to this being rolled out?

hannah-hyj
hannah-hyj approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit auto-submit bot merged commit 0023d01 into flutter:main Sep 18, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
0023d01 [go_router] Adds on exit (flutter/packages#4699)
380dda1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
0023d01 [go_router] Adds on exit (flutter/packages#4699)
ebca69b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
0023d01 [go_router] Adds on exit (flutter/packages#4699)
e595244
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
0023d01 [go_router] Adds on exit (flutter/packages#4699)
a2dc32d
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (#135145)
3a78e5c 
flutter/packages@d4e2454...51e74b9

2023-09-19 stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
pro100andrey added a commit to pro100andrey/packages that referenced this pull request Sep 25, 2023
@pro100andrey
Merge branch 'main' into feature/fix
6787627 
* main: (590 commits)
  Bump github/codeql-action from 2.21.7 to 2.21.8 (flutter#4952)
  Manual roll Flutter from 8936504 to f92884c (48 revisions) (flutter#4985)
  [image_picker_android] check if data from result is empty when picking a single img or video (flutter#4836)
  [camera_android] Removes usage of `_ambiguate` method in tests (flutter#4948)
  [sign_in]: Bump com.google.android.gms:play-services-auth from 20.6.0 to 20.7.0 in /packages/google_sign_in/google_sign_in_android/android (flutter#4841)
  Manual roll Flutter (stable) from 367f9ea16bfa to 12fccda59847 (2 revisions) (flutter#4976)
  [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… (flutter#4723)
  [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter#4703)
  [various] Update invalid NSURL tests (flutter#4959)
  [ios_platform_images] Convert to Pigeon (flutter#4945)
  [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter#4880)
  Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter#4947)
  [go_router] Adds on exit (flutter#4699)
  [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter#4713)
  [file_selector] Fix unknown extensions on macOS (flutter#4946)
  [camera_avfoundation] ignore audio samples until first video sample (flutter#4587)
  Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter#4944)
  [video_player] isCompleted event. (flutter#4923)
  [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter#4881)
  [google_sign_in] Convert iOS to Pigeon (flutter#4941)
  ...

# Conflicts:
#	packages/camera/camera/pubspec.yaml
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter#135145)
8a149ab 
flutter/packages@d4e2454...51e74b9

2023-09-19 stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@benjaminledet benjaminledet mentioned this pull request Oct 27, 2023
Closed
2 tasks
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@chunhtai @HugoOlthof
[go_router] Adds on exit (flutter#4699)
2c5aa62 
related flutter/flutter#102408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaronbracke navaronbracke navaronbracke left review comments

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunhtai @MendleM @navaronbracke @hannah-hyj