Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router_builder] Generate initialLocation with StatefulShellBranchConfig #4880

Merged
merged 11 commits into from
Sep 19, 2023
Merged

[go_router_builder] Generate initialLocation with StatefulShellBranchConfig #4880

merged 11 commits into from
Sep 19, 2023

Conversation

GeekAbdelouahed
Copy link
Contributor

@GeekAbdelouahed GeekAbdelouahed commented Sep 10, 2023 •
edited
Loading

Add the possibility to generate initialLocation with StatefulShellBranchConfig

before:

class MyRoute extends StatefulShellBranchData {
  const MyRoute();
}

after:

class MyRoute extends StatefulShellBranchData {
  const MyRoute();

  static const String $initialLocation = '/my-route';
}

List which issues are fixed by this PR. You must list at least one issue.
issues/130786

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Sep 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GeekAbdelouahed GeekAbdelouahed changed the title feat: add initialLocation to StatefulShellBranchConfig [go_router_builder] Generate initialLocation with StatefulShellBranchConfig Sep 10, 2023
@chunhtai chunhtai requested review from hannah-hyj and removed request for chunhtai September 14, 2023 20:51
hannah-hyj
hannah-hyj reviewed Sep 18, 2023
View reviewed changes
packages/go_router_builder/CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
## 2.3.2
* Add initialLocation with StatefulShellBranchConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Adds

@hannah-hyj
Copy link
Member

@GeekAbdelouahed Thanks for the contribution! Can you also add tests to this PR?

hannah-hyj
hannah-hyj approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

chunhtai
chunhtai approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a format nit

packages/go_router_builder/test_inputs/statefull_shell_branch_data.dart.expect Outdated
@@ -0,0 +1,3 @@
RouteBase get $shellRouteBranchData => StatefulShellBranchData.$branch(
initialLocation: ShellRouteBranchData.$initialLocation,
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunhtai updated

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2023
@auto-submit auto-submit bot merged commit d08ebfd into flutter:main Sep 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
d08ebfd [go_router_builder] Generate initialLocation with StatefulShe…
a94d872 
…llBranchConfig (flutter/packages#4880)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
d08ebfd [go_router_builder] Generate initialLocation with StatefulShe…
f743be5 
…llBranchConfig (flutter/packages#4880)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (#135145)
3a78e5c 
flutter/packages@d4e2454...51e74b9

2023-09-19 stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
pro100andrey added a commit to pro100andrey/packages that referenced this pull request Sep 25, 2023
@pro100andrey
Merge branch 'main' into feature/fix
6787627 
* main: (590 commits)
  Bump github/codeql-action from 2.21.7 to 2.21.8 (flutter#4952)
  Manual roll Flutter from 8936504 to f92884c (48 revisions) (flutter#4985)
  [image_picker_android] check if data from result is empty when picking a single img or video (flutter#4836)
  [camera_android] Removes usage of `_ambiguate` method in tests (flutter#4948)
  [sign_in]: Bump com.google.android.gms:play-services-auth from 20.6.0 to 20.7.0 in /packages/google_sign_in/google_sign_in_android/android (flutter#4841)
  Manual roll Flutter (stable) from 367f9ea16bfa to 12fccda59847 (2 revisions) (flutter#4976)
  [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… (flutter#4723)
  [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter#4703)
  [various] Update invalid NSURL tests (flutter#4959)
  [ios_platform_images] Convert to Pigeon (flutter#4945)
  [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter#4880)
  Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter#4947)
  [go_router] Adds on exit (flutter#4699)
  [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter#4713)
  [file_selector] Fix unknown extensions on macOS (flutter#4946)
  [camera_avfoundation] ignore audio samples until first video sample (flutter#4587)
  Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter#4944)
  [video_player] isCompleted event. (flutter#4923)
  [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter#4881)
  [google_sign_in] Convert iOS to Pigeon (flutter#4941)
  ...

# Conflicts:
#	packages/camera/camera/pubspec.yaml
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter#135145)
8a149ab 
flutter/packages@d4e2454...51e74b9

2023-09-19 stuartmorgan@google.com [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 abdeluached@gmail.com [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 engine-flutter-autoroll@skia.org Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 47866232+chunhtai@users.noreply.github.com [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 stuartmorgan@google.com [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 30872003+misos1@users.noreply.github.com [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 engine-flutter-autoroll@skia.org Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 tarrinneal@gmail.com [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 stuartmorgan@google.com [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 stuartmorgan@google.com Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@GeekAbdelouahed @HugoOlthof
[go_router_builder] Generate initialLocation with StatefulShellBranch…
82ae034 
…Config (flutter#4880)

Add the possibility to generate `initialLocation` with `StatefulShellBranchConfig`

before:
```dart
class MyRoute extends StatefulShellBranchData {
  const MyRoute();
}
```

after:
```dart
class MyRoute extends StatefulShellBranchData {
  const MyRoute();

  static const String $initialLocation = '/my-route';
}
```

*List which issues are fixed by this PR. You must list at least one issue.*
[issues/130786](flutter/flutter#130786 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeekAbdelouahed @hannah-hyj @chunhtai