Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder] Generate initialLocation with StatefulShellBranchConfig #4880

Merged
merged 11 commits into from
Sep 19, 2023
Merged

[go_router_builder] Generate initialLocation with StatefulShellBranchConfig #4880

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80e5cf1
feat: add initialLocation to StatefulShellBranchConfig
GeekAbdelouahed Sep 10, 2023
c8079d3
chore: update CHANGELOG.md and pubspec.yaml
GeekAbdelouahed Sep 10, 2023
8866014
Merge branch 'main' into main
GeekAbdelouahed Sep 13, 2023
2749af0
feat: add unit test
GeekAbdelouahed Sep 18, 2023
873ce66
feat: add stateful shell route initial location example
GeekAbdelouahed Sep 18, 2023
072315a
feat: add widget test for stateful shell route initial location example
GeekAbdelouahed Sep 18, 2023
3471010
Merge branch 'main' of https://github.com/GeekAbdelouahed/packages
GeekAbdelouahed Sep 18, 2023
742cccf
Merge branch 'main' into main
GeekAbdelouahed Sep 18, 2023
7c42500
chore: update pubspec.yaml
GeekAbdelouahed Sep 18, 2023
5474657
feat: ignore public_member_api_docs
GeekAbdelouahed Sep 18, 2023
f148d47
feat: update stefull shell branch test
GeekAbdelouahed Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.3.2
* Add initialLocation with StatefulShellBranchConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Adds


## 2.3.1

* Adds pub topics to package metadata.
Expand Down
11 changes: 10 additions & 1 deletion packages/go_router_builder/lib/src/route_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ class StatefulShellBranchConfig extends RouteBaseConfig {
required super.routeDataClass,
required super.parent,
this.restorationScopeId,
this.initialLocation,
}) : super._();

/// The command for calling the navigator key getter from the ShellRouteData.
Expand All @@ -145,6 +146,9 @@ class StatefulShellBranchConfig extends RouteBaseConfig {
/// The restoration scope id.
final String? restorationScopeId;

/// The initial route.
final String? initialLocation;

@override
Iterable<String> classDeclarations() => <String>[];

Expand All @@ -153,7 +157,8 @@ class StatefulShellBranchConfig extends RouteBaseConfig {
@override
String get routeConstructorParameters =>
'${navigatorKey == null ? '' : 'navigatorKey: $navigatorKey,'}'
'${restorationScopeId == null ? '' : 'restorationScopeId: $restorationScopeId,'}';
'${restorationScopeId == null ? '' : 'restorationScopeId: $restorationScopeId,'}'
'${initialLocation == null ? '' : 'initialLocation: $initialLocation,'}';

@override
String get routeDataClassName => 'StatefulShellBranchData';
Expand Down Expand Up @@ -502,6 +507,10 @@ abstract class RouteBaseConfig {
classElement,
parameterName: r'$restorationScopeId',
),
initialLocation: _generateParameterGetterCode(
classElement,
parameterName: r'$initialLocation',
),
);
break;
case 'TypedGoRoute':
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 2.3.1
version: 2.3.2
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand Down