[shared_preferences] fix documentation wording #4986
Conversation
|
Ok I don't know why |
tarrinneal
added
the
autosubmit
|
auto label is removed for flutter/packages/4986, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
|
I always forget that one... @stuartmorgan for second approval? |
| @@ -1,3 +1,7 @@ | |||
| ## 2.2.2 | |||
|
|
|||
| * Updates documentation for `containsKey` | |||
There was a problem hiding this comment.
This is missing a period; please see the CHANGELOG style guide linked from the PR checklist.
There was a problem hiding this comment.
Sorry 😅
I also just queued the changes for NEXT as I don't think a version bump is needed. Correct me if I should change it back.
There was a problem hiding this comment.
Which exemption reason linked from the PR checklist would this PR fall under?
There was a problem hiding this comment.
Ok I somehow miss read
Non-code changes that we make to future-proof development in some way, but don't directly benefit clients. Examples of this include
And only saw the part with Non-code changes.
I'll revert it again.
|
Not for this PR, but someday we should fix all those comments; saying they are reading from/checking/etc. "persistent storage" is highly misleading given that there is at least one, and on most platforms two, layers of cache involved. |
Leptopoda
force-pushed
the
fix/shared_prefs/docs
branch
2 times, most recently
from
fea732d
to
ea466b8
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
fix/shared_prefs/docs
branch
from
ea466b8
to
560ff2c
Compare
stuartmorgan
added
the
autosubmit
flutter/packages@4b483f2...93c3f69 2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121) 2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416) 2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081) 2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106) 2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096) 2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903) 2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986) 2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter/packages#5104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The wording of the `SharedPreferences.containsKey` docs was off. This PR improves the documentation. none. I can open an issue if really necessary. n.a.
The wording of the
SharedPreferences.containsKeydocs was off. This PR improves the documentation.none. I can open an issue if really necessary.
n.a.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.