[flutter_markdown] Fix typo in readme #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,10 +17,10 @@ containing a rich text representation. | |||
| the Markdown into an abstract syntax tree (AST). The nodes of the AST are an | |||
| HTML representation of the Markdown data. | |||
|
|
|||
| ## Flutter Isn't a HTML Renderer | |||
| ## Flutter Isn't an HTML Renderer | |||
There was a problem hiding this comment.
I'd argue the H in HTML is sounded, and thus a is correct in this position per https://owl.purdue.edu/owl/general_writing/grammar/articles_a_versus_an.html
Hey @sfshaza2 or @atsansone wanna tie break?
There was a problem hiding this comment.
In the link, there is no instance of "a h", but twice "an h"
Exceptions
Use "an" before a silent or unsounded "h." Because the "h" does not have any phonetic representation or audible sound, the sound that follows the article is a vowel; consequently, "an" is used.
an honorable peace
an honest error
There was a problem hiding this comment.
I'd argue the H in HTML is sounded
For an initialism it doesn't really make sense to say a letter is sounded or unsounded; the sound of the letters isn't used at all.
The deciding factor is the pronunciation of the letter H as a word. Since Flutter style uses US English spelling, we should spell this based on prevailing US pronunciation (which starts with an "ay"/"ai" sound), making "an" correct.
nohli
commented
Oct 10, 2023
nohli
commented
Oct 10, 2023
stuartmorgan
requested changes
Oct 10, 2023
nohli
commented
Oct 10, 2023
nohli
commented
Oct 10, 2023
domesticmouse
approved these changes
Oct 10, 2023
stuartmorgan
approved these changes
Oct 10, 2023
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2023
flutter/packages@4b483f2...93c3f69 2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121) 2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416) 2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081) 2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106) 2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096) 2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903) 2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986) 2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter/packages#5104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
Since HTML is pronounced with an A at the beginning (at least by around [85%](https://english.stackexchange.com/a/23762) of people), it should [probably](https://english.stackexchange.com/a/25746) be spelled `an HTML`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HTML is pronounced with an A at the beginning (at least by around 85% of people), it should probably be spelled
an HTML.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.