[video_player] Endorse macOS #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endorses the macOS implementation of `video_player`, updating the constraint of the existing `video_player_avfoundation` dependency to ensure macOS support is present. Adds macOS support to the example, and adds macOS discussion to the README. Fixes flutter/flutter#41688
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This comment was marked as outdated.
This comment was marked as outdated.
tarrinneal
approved these changes
Sep 28, 2023
stuartmorgan
added
the
autosubmit
|
Overriding stale commit queue check. |
stuartmorgan
added
the
emergency
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2023
flutter/packages@c070b0a...d0e9a0e 2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011) 2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022) 2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@c070b0a...d0e9a0e 2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011) 2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022) 2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
Endorses the macOS implementation of `video_player`, updating the constraint of the existing `video_player_avfoundation` dependency to ensure macOS support is present. Adds macOS support to the example, and adds macOS discussion to the README. This is the first macOS plugin with multiple integration test files, which turned up a bug in `flutter test`, so this also includes a repo tooling change to work around that bug for now by running each integration test file separately on macOS (as we already have to do with `flutter drive` on web). Fixes flutter/flutter#41688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endorses the macOS implementation of
video_player, updating the constraint of the existingvideo_player_avfoundationdependency to ensure macOS support is present. Adds macOS support to the example, and adds macOS discussion to the README.This is the first macOS plugin with multiple integration test files, which turned up a bug in
flutter test, so this also includes a repo tooling change to work around that bug for now by running each integration test file separately on macOS (as we already have to do withflutter driveon web).Fixes flutter/flutter#41688
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).