[camera] Fix Android autofocus state reading #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine. Fixes flutter/flutter#135554 Part of flutter/flutter#84957
camsim99
approved these changes
Sep 28, 2023
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2023
flutter/packages@c070b0a...d0e9a0e 2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011) 2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022) 2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@c070b0a...d0e9a0e 2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021) 2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c to ff4a0f6 (107 revisions) (flutter/packages#5011) 2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025) 2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda to ead4559 (1 revision) (flutter/packages#5022) 2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine. Fixes flutter/flutter#135554 Part of flutter/flutter#84957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo introduced during a testability refactor that caused the capture state machine to read the wrong value for autofocus state, breaking the state machine.
Fixes flutter/flutter#135554
Part of flutter/flutter#84957
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).