[Android] Introduces API 34 emulators for subset of tests #5105
Conversation
|
@stuartmorgan I'm seeing failures on https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_platform_tests_api_33_shard_1%20master/9/overview because |
|
Yes, it looks like |
Ah good catch, thank you! |
|
It would have been a better catch if I'd noticed when I reviewed PR adding that script :) |
| @@ -2,3 +2,4 @@ | |||
| - file_selector | |||
| - quick_actions | |||
| - webview_flutter | |||
| - path_provider | |||
There was a problem hiding this comment.
Excluding this as well because there are persistent flakes, as I attempted to fix in #5098
camsim99
added
the
autosubmit
flutter/packages@2faf992...f751ffb 2023-10-25 stuartmorgan@google.com [ci] Enable legacy Android emulator tests (flutter/packages#5190) 2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209) 2023-10-25 godofredoc@google.com Replace gems dependency with ruby. (flutter/packages#5219) 2023-10-25 godofredoc@google.com Update the ftl hardware version. (flutter/packages#5224) 2023-10-25 737941+loic-sharma@users.noreply.github.com [ci] Disable Windows Arm64 stable CI (flutter/packages#5217) 2023-10-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137) 2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155) 2023-10-24 43054281+camsim99@users.noreply.github.com [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105) 2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211) 2023-10-24 stuartmorgan@google.com [ci] Fix legacy Android task names (flutter/packages#5191) 2023-10-24 reidbaker@google.com Update annotations deps to 1.7 (flutter/packages#4935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Introduces API 34 emulators for subset of tests not causing test failures in flutter#4804. Also changes linux_android version to 34v1. Continuation of flutter#4820.
Introduces API 34 emulators for subset of tests not causing test failures in #4804.
Also changes linux_android version to 34v1.Undid this change because it was causing flutter/flutter#135756Continuation of #4820.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).