[webview_flutter_wkwebview] Only set limitsNavigationsToAppBoundDomains when it is set to true
#5137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
limitsNavigationsToAppBoundDomains when it is set to true
stuartmorgan-g
approved these changes
Oct 13, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix on this.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2023
…oundDomains` when it is set to true (flutter/packages#5137)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 25, 2023
flutter/packages@2faf992...f751ffb 2023-10-25 stuartmorgan@google.com [ci] Enable legacy Android emulator tests (flutter/packages#5190) 2023-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.0 to 2.3.1 (flutter/packages#5209) 2023-10-25 godofredoc@google.com Replace gems dependency with ruby. (flutter/packages#5219) 2023-10-25 godofredoc@google.com Update the ftl hardware version. (flutter/packages#5224) 2023-10-25 737941+loic-sharma@users.noreply.github.com [ci] Disable Windows Arm64 stable CI (flutter/packages#5217) 2023-10-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Only set `limitsNavigationsToAppBoundDomains` when it is set to true (flutter/packages#5137) 2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode (flutter/packages#5155) 2023-10-24 43054281+camsim99@users.noreply.github.com [Android] Introduces API 34 emulators for subset of tests (flutter/packages#5105) 2023-10-24 stuartmorgan@google.com [url_launcher] Add an `inAppBrowserView` mode in implementations (flutter/packages#5211) 2023-10-24 stuartmorgan@google.com [ci] Fix legacy Android task names (flutter/packages#5191) 2023-10-24 reidbaker@google.com Update annotations deps to 1.7 (flutter/packages#4935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the flag to only flag to only call the method if it sets it to
true.Fixes flutter/flutter#136449
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.