[url_launcher] Simplify Linux implementation #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol. This also adds direct support for `launchUrl`, so we're no longer relying on the redirection from the deprecated `launch`.
|
I noticed Linux had never been cleaned up after switching to per-package channels while I was working on the Windows implementation. |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol. This also adds direct support for `launchUrl`, so we're no longer relying on the redirection from the deprecated `launch`.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2023
flutter/packages@80aa46a...b5958e2 2023-12-13 43054281+camsim99@users.noreply.github.com [camera, camera_android] Re-enable passing integration tests (flutter/packages#5658) 2023-12-13 engine-flutter-autoroll@skia.org Roll Flutter from 9719097 to 11a9cb7 (32 revisions) (flutter/packages#5665) 2023-12-13 stuartmorgan@google.com [url_launcher] Return false on Windows when there is no handler (flutter/packages#5359) 2023-12-13 stuartmorgan@google.com [url_launcher] Simplify Linux implementation (flutter/packages#5376) 2023-12-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.1 to 1.6.2 in /packages/local_auth/local_auth_android/android (flutter/packages#5332) 2023-12-12 tarrinneal@gmail.com [pigeon] Adds @CanIgnoreReturnValue annotation (flutter/packages#5601) 2023-12-12 tarrinneal@gmail.com [image_picker] updates to resize logic. (flutter/packages#5527) 2023-12-12 stuartmorgan@google.com [various] Update examples using video_player (flutter/packages#5653) 2023-12-12 louisehsu@google.com [tools] Validate pubspec topic format (flutter/packages#5565) 2023-12-12 nathan2000@outlook.com [pigeon] Fix Kotlin generator to use provided errorClassName (flutter/packages#5480) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
foxtrotravi
pushed a commit
to foxtrotravi/packages
that referenced
this pull request
Dec 14, 2023
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol. This also adds direct support for `launchUrl`, so we're no longer relying on the redirection from the deprecated `launch`.
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol. This also adds direct support for `launchUrl`, so we're no longer relying on the redirection from the deprecated `launch`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux implementation's method channel code was never simplified after the switch from a shared method channel to per-package method channels, so there was still cruft from the cross-platform channel API. This removes everything that's not used by the Linux native implementation, simplifying the protocol.
This also adds direct support for
launchUrl, so we're no longer relying on the redirection from the deprecatedlaunch.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).