Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigeon] Fix Kotlin generator to use provided errorClassName #5480

Merged
merged 6 commits into from
Dec 12, 2023
Merged

[pigeon] Fix Kotlin generator to use provided errorClassName #5480

merged 6 commits into from
Dec 12, 2023

Conversation

NathanKolbas
Copy link
Contributor

@NathanKolbas NathanKolbas commented Nov 26, 2023 •
edited by tarrinneal
Loading

Fix bug with Pigeon Kotlin code generator not using the provided errorClassName.

fixes: flutter/flutter#139031

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@NathanKolbas NathanKolbas changed the title [Pigeon] Update kotlin generator to use provided errorClassName [Pigeon] Fix Kotlin generator to use provided errorClassName Nov 26, 2023
@NathanKolbas NathanKolbas changed the title [Pigeon] Fix Kotlin generator to use provided errorClassName [pigeon] Fix Kotlin generator to use provided errorClassName Nov 27, 2023
tarrinneal
tarrinneal requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good update, can you run the generate tool, and upload the new kotlin files as well?

packages/pigeon/CHANGELOG.md Outdated Show resolved Hide resolved
@NathanKolbas
Copy link
Contributor Author

This is a good update, can you run the generate tool, and upload the new kotlin files as well?

Thank you! I ran the generate tool (dart run tool/generate.dart) in the pigeon package directory, however, git reported no changes. Am I running the correct command, maybe I am missing something, or perhaps that was an expected outcome?

@tarrinneal
Copy link
Contributor

Thank you! I ran the generate tool (dart run tool/generate.dart) in the pigeon package directory, however, git reported no changes. Am I running the correct command, maybe I am missing something, or perhaps that was an expected outcome?

Probably just means we aren't using this in any of our integration tests. Which also means we probably need to add this to our integration tests...

tarrinneal
tarrinneal approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to do the extra work to add this to our integration tests, you'd make me a happy person, I think this is fine to land as is though. @stuartmorgan for second review.

stuartmorgan
stuartmorgan requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely have an integration test covering this as part of the PR, either to catch the fact that this is breaking or to make it easy for me to see why it's not breaking (depending on which is the case).

packages/pigeon/CHANGELOG.md Show resolved Hide resolved
@tarrinneal tarrinneal mentioned this pull request Dec 7, 2023
Closed
11 tasks
@NathanKolbas
Copy link
Contributor Author

If you want to do the extra work to add this to our integration tests, you'd make me a happy person, I think this is fine to land as is though. @stuartmorgan for second review.

I apologize I was unable to get back to this PR sooner... Thank you for trying to push it forward! Sorry you couldn't push to the PR. Is there anything else I can do to help out? Should I close this merge request or merge in your changes?

@tarrinneal
Copy link
Contributor

I apologize I was unable to get back to this PR sooner...

No problem, I appreciate you putting it together! I think you'll get credited the same with your pr or mine, so I'll probably close this one and stick with mine. If that's ok with you?

If you'd prefer, you can pull my changes and we can push yours through instead! Just let me know.

@NathanKolbas
Copy link
Contributor Author

@tarrinneal I merged in your changes and also merged in upstream/main and resolved conflicts. I would love to see my PR get merged in (just because this is my "first" public contribution to an open-source project)! But honestly, it doesn't make a difference, whatever is easier for you guys. Thanks!

@tarrinneal
Copy link
Contributor

@tarrinneal I merged in your changes and also merged in upstream/main and resolved conflicts. I would love to see my PR get merged in (just because this is my "first" public contribution to an open-source project)! But honestly, it doesn't make a difference, whatever is easier for you guys. Thanks!

Of course! I'd prefer to push your pr through anyway.

tarrinneal
tarrinneal requested changes Dec 12, 2023
View reviewed changes
packages/pigeon/CHANGELOG.md Outdated Show resolved Hide resolved
tarrinneal
tarrinneal approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. Thanks again for putting this together.

stuartmorgan
stuartmorgan approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 12, 2023
@auto-submit auto-submit bot merged commit 4147244 into flutter:main Dec 12, 2023
79 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll
4147244 [pigeon] Fix Kotlin generator to use provided errorClassName (f…
3dee129 
…lutter/packages#5480)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll
4147244 [pigeon] Fix Kotlin generator to use provided errorClassName (f…
68372f8 
…lutter/packages#5480)
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@NathanKolbas @HugoOlthof
[pigeon] Fix Kotlin generator to use provided errorClassName (flutter…
460021b 
…#5480)

Fix bug with Pigeon Kotlin code generator not using the provided `errorClassName`.

fixes: flutter/flutter#139031

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll
4147244 [pigeon] Fix Kotlin generator to use provided errorClassName (f…
25973d4 
…lutter/packages#5480)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll
Roll Packages from 80aa46a to b5958e2 (10 revisions) (#140069)
3751005 
flutter/packages@80aa46a...b5958e2

2023-12-13 43054281+camsim99@users.noreply.github.com [camera, camera_android] Re-enable passing integration tests (flutter/packages#5658)
2023-12-13 engine-flutter-autoroll@skia.org Roll Flutter from 9719097 to 11a9cb7 (32 revisions) (flutter/packages#5665)
2023-12-13 stuartmorgan@google.com [url_launcher] Return false on Windows when there is no handler (flutter/packages#5359)
2023-12-13 stuartmorgan@google.com [url_launcher] Simplify Linux implementation (flutter/packages#5376)
2023-12-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.1 to 1.6.2 in /packages/local_auth/local_auth_android/android (flutter/packages#5332)
2023-12-12 tarrinneal@gmail.com [pigeon] Adds @CanIgnoreReturnValue annotation (flutter/packages#5601)
2023-12-12 tarrinneal@gmail.com [image_picker] updates to resize logic. (flutter/packages#5527)
2023-12-12 stuartmorgan@google.com [various] Update examples using video_player (flutter/packages#5653)
2023-12-12 louisehsu@google.com [tools] Validate pubspec topic format (flutter/packages#5565)
2023-12-12 nathan2000@outlook.com [pigeon] Fix Kotlin generator to use provided errorClassName (flutter/packages#5480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
foxtrotravi pushed a commit to foxtrotravi/packages that referenced this pull request Dec 14, 2023
@NathanKolbas @foxtrotravi
[pigeon] Fix Kotlin generator to use provided errorClassName (flutter…
eaa2ca3 
…#5480)

Fix bug with Pigeon Kotlin code generator not using the provided `errorClassName`.

fixes: flutter/flutter#139031

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@NathanKolbas @arc-yong
[pigeon] Fix Kotlin generator to use provided errorClassName (flutter…
b7b3c3e 
…#5480)

Fix bug with Pigeon Kotlin code generator not using the provided `errorClassName`.

fixes: flutter/flutter#139031

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pigeon platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pigeon] KotlinOptions errorClassName not used in Kotlin to Dart communication
3 participants
@NathanKolbas @tarrinneal @stuartmorgan