[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

tolo · 2024-04-05T16:08:20Z

Adds support for preloading branches in a StatefulShellRoute. This functionality was initially part of an early implementation of #2650, however it was decided to implement this in a separate PR. The current implementation is a rewrite of the original implementation to better fit the final version of StatefulShellRoute (and go_router in general).

NOTE: this is a revised version of the initial solution (see #4251), containing a substantially simpler implementation made possible thanks to recent refactoring in go_router.

This fixes issue flutter/flutter#127804.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…nto statefulshellroute-preload-v2

chunhtai · 2024-04-29T22:24:03Z

I know I have been slacking off at this pr. I am sorry about this. My schedule is quite tight after I came back from vacation. This is still under my radar. I will try find time review this pr within 2 weeks

tolo · 2024-04-30T12:26:09Z

I know I have been slacking off at this pr. I am sorry about this. My schedule is quite tight after I came back from vacation. This is still under my radar. I will try find time review this pr within 2 weeks

No worries @chunhtai, I completely understand, have had far too much on my plate myself the last year 😅

packages/go_router/lib/src/route.dart

cedvdb · 2024-05-22T10:24:38Z

packages/go_router/example/lib/stateful_shell_route.dart

@@ -60,6 +60,9 @@ class NestedTabNavigationExampleApp extends StatelessWidget {
                ],
              ),
            ],
+            // To enable preloading of the initial locations of branches, pass
+            // 'true' for the parameter preload.
+            // preload: true,


I'd find it clearer if the last line was uncommented as preload: false

You may be right, I'll consider this.

packages/go_router/lib/src/route.dart

unacorbatanegra · 2024-05-30T14:44:00Z

Any updates on this?

chunhtai

Overall LGTM, just some comments

packages/go_router/lib/src/route.dart

chunhtai · 2024-06-07T20:42:04Z

packages/go_router/lib/src/route.dart

@@ -1255,8 +1291,39 @@ class StatefulNavigationShellState extends State<StatefulNavigationShell>
    final bool locationChanged =
        previousBranchLocation != currentBranchLocation;
    if (locationChanged || !hasExistingNavigator) {
-      _branchNavigators[branch.navigatorKey] = shellRouteContext
-          .navigatorBuilder(branch.observers, branch.restorationScopeId);
+      _branchNavigators[branch.navigatorKey] =


just realized somewhere in this method should probably remove entries in _branchNavigators the are no longer in the StatefulShellRoute?

You're right, that is definitely necessary to do now. Will have a look at it.

@chuntai, I added a fix for removing old entries, but when attempting to write a test case, I ran into issues with duplicate GlobalKeys (_shellStateKey) when updating the dynamic RoutingConfig. Or - I should be clear - at first the test case worked, but not because of the code I added, but instead because the entire StatefulShellRoute was replaced/reloaded. But when I added the possibility to set the GlobalKey<StatefulNavigationShellState> _shellStateKey to maintain state, I started to get this error.

When trying to troubleshoot it, I started to wonder whether dynamic RoutingConfig full supports ShellRoutes, at least with state. Added some test cases to test this, and it seems simple StatefulWidgets in a simple routing scenario works, but when adding a (regular) ShellRoute with a stateful shell I also get and issue with duplicate GlobalKeys.

Not sure if I just missed something, but I anyway added a gist with the test cases here: https://gist.github.com/tolo/922fd838cdea30b17121533b0012eda4

can you file an issue for it? looks like a bug

is the fix in this pr already?

It is now. 😊 Note though that I disabled two tests that fail due to the issue I mentioned above.

cedvdb · 2024-07-03T12:10:40Z

What's the status here ? It seems like you said that you have a test locally that's failing but it's unrelated to the changes here ?

tolo · 2024-07-10T06:58:33Z

What's the status here ? It seems like you said that you have a test locally that's failing but it's unrelated to the changes here ?

Yes, @chunhtai, have you had a chance to too look at my comment above (#6467 (comment))?

The issue is however only with testing if obsolete branch navigators are removed (which is done dynamic RoutingConfig), so possibly this could be moved to a separate issue/PR. And another issue should probably be opened for fixing the support for dynamic RoutingConfig for (stateful) shell routes. What do you think @chunhtai?

chunhtai · 2024-07-11T21:37:42Z

will take a look this week

packages/go_router/example/lib/others/custom_stateful_shell_route.dart

packages/go_router/lib/src/route.dart

chunhtai · 2024-07-16T17:25:03Z

packages/go_router/lib/src/route.dart

@@ -1255,8 +1291,39 @@ class StatefulNavigationShellState extends State<StatefulNavigationShell>
    final bool locationChanged =
        previousBranchLocation != currentBranchLocation;
    if (locationChanged || !hasExistingNavigator) {
-      _branchNavigators[branch.navigatorKey] = shellRouteContext
-          .navigatorBuilder(branch.observers, branch.restorationScopeId);
+      _branchNavigators[branch.navigatorKey] =


can you file an issue for it? looks like a bug

chunhtai · 2024-07-16T17:26:12Z

packages/go_router/lib/src/route.dart

@@ -1255,8 +1291,39 @@ class StatefulNavigationShellState extends State<StatefulNavigationShell>
    final bool locationChanged =
        previousBranchLocation != currentBranchLocation;
    if (locationChanged || !hasExistingNavigator) {
-      _branchNavigators[branch.navigatorKey] = shellRouteContext
-          .navigatorBuilder(branch.observers, branch.restorationScopeId);
+      _branchNavigators[branch.navigatorKey] =


is the fix in this pr already?

(Note: issues with dynamic route config)

Shunt22 · 2024-08-02T18:30:46Z

Any status update?
Would love to have this feature in my project.

…rrors).

tolo · 2024-08-19T19:17:43Z

@chunhtai, as mentioned above, I've included the fix for cleaning obsolete branches. But I'm thinking it might be better to postpone that fix until the issues with duplicate GlobalKeys is resolved.

cedvdb · 2024-08-20T06:00:27Z

packages/go_router/lib/src/route.dart

+
+        final Widget navigator = widget.shellRouteContext.navigatorBuilder(
+          branch.navigatorKey,
+          match!,


! can be removed on this line

Oh? Maybe I'm missing something, but that gives me an error (since match is ShellRouteMatch?). Would have been nice if the assert would have that effect though.

cedvdb · 2024-09-16T21:05:44Z

@chunhtai can this PR get some love ? (feedback)

tolo · 2024-09-17T19:46:18Z

FYI, for those interested in StatefulShellRoute evolution, there is a related (draft) PR in the works: #7622. There are some ideas around quality-of-life improvements around StatefulShellRoute in there, so have a look if you're interested.

chunhtai

LGTM

packages/go_router/lib/src/route.dart

…preload-v2

…ple (#7583) Updated `custom_stateful_shell_route.dart` example to better support swiping in TabView. Also added code to demonstrate use of PageView instead of TabView. Note that to be fully effective from a usability perspective, the PR #6467 (branch preloading) need also be merged. This PR addresses: * flutter/flutter#150837 * flutter/flutter#112267 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

hannah-hyj

LGTM!

Shunt22 · 2024-10-24T11:14:27Z

Hi!
Sorry, when will this be live?

chunhtai · 2024-11-07T22:34:24Z

Hi @tolo can you rebase and then we can merge?

cedvdb · 2024-11-07T22:51:11Z

@chunhtai Can autosubmit be added ? as conflicts were already resolved 2 weeks ago

auto-submit · 2024-11-07T23:04:56Z

auto label is removed for flutter/packages/6467, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

chunhtai · 2024-11-07T23:15:05Z

Looks like there is some outdated excerpt
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731887329080081345/+/u/Run_package_tests/README_snippet_validation/stdout?format=raw

I can't fix it through gihub ui. @tolo can you try to fix it?

…preload-v2

…ShellRoute (revised solution) (flutter/packages#6467)

flutter/packages@72356fd...26e123a 2024-11-13 dasyad00@gmail.com [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 39979207+ThangVuNguyenViet@users.noreply.github.com [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 pq@users.noreply.github.com [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 feinstein@users.noreply.github.com [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 stuartmorgan@google.com [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 ditman@gmail.com [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 stuartmorgan@google.com [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 tobias@leafnode.se [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 stuartmorgan@google.com [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 engine-flutter-autoroll@skia.org Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 magder@google.com Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 stuartmorgan@google.com [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 stuartmorgan@google.com [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 stuartmorgan@google.com [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 magder@google.com Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 43054281+camsim99@users.noreply.github.com [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 magder@google.com Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 37028599+EArminjon@users.noreply.github.com [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 stuartmorgan@google.com [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

tolo added 4 commits March 12, 2024 18:14

Added support for branch preloading

d4f2d0d

Added support for branch preloading

fc00590

Updated version and CHANGELOG

62b9894

Merge remote-tracking branch 'origin/statefulshellroute-preload-v2' i…

126787f

…nto statefulshellroute-preload-v2

tolo requested a review from chunhtai as a code owner April 5, 2024 16:08

github-actions bot added the p: go_router label Apr 5, 2024

tolo mentioned this pull request Apr 5, 2024

[go_router] Add support for preloading branches of StatefulShellRoute #4251

Closed

11 tasks

cedvdb reviewed May 22, 2024

View reviewed changes

packages/go_router/lib/src/route.dart Show resolved Hide resolved

cedvdb reviewed May 22, 2024

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

cedvdb reviewed May 22, 2024

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

tolo added 2 commits June 3, 2024 20:48

Some refinements and some updates from PR feedback.

b0a92bf

Merged from upstream/main

eb3db3b

chunhtai reviewed Jun 7, 2024

View reviewed changes

chunhtai self-requested a review June 20, 2024 21:41

riscait mentioned this pull request Jun 26, 2024

[go_router] In TabBarView with StatefulShellBranch, content remains Blank when swiping to switch between tabs flutter/flutter#150837

Open

chunhtai reviewed Jul 16, 2024

View reviewed changes

tolo added 2 commits July 26, 2024 17:21

Improved description of preload property.

c2eb9b1

Cleanup obsolete branches

5d93833

(Note: issues with dynamic route config)

tolo added 2 commits August 15, 2024 16:39

Added branch cleanup code and tests (Note: some are disabled due to e…

523bf75

…rrors).

Merged from upstream/main

ca3e898

cedvdb reviewed Aug 20, 2024

View reviewed changes

chunhtai approved these changes Sep 20, 2024

View reviewed changes

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

packages/go_router/lib/src/route.dart Outdated Show resolved Hide resolved

tolo added 2 commits September 24, 2024 15:48

Code style cleanup.

9d68693

Merge remote-tracking branch 'upstream/main' into statefulshellroute-…

604744b

…preload-v2

chunhtai requested a review from hannah-hyj October 3, 2024 21:40

hannah-hyj approved these changes Oct 14, 2024

View reviewed changes

tolo added 2 commits October 23, 2024 06:40

Merged from upstream/main

4bed9fd

Bumped version and fixed formatting.

a5f6600

Merge branch 'main' into statefulshellroute-preload-v2

1b85750

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2024

tolo added 2 commits November 9, 2024 18:33

Merge remote-tracking branch 'upstream/main' into statefulshellroute-…

6b50167

…preload-v2

Updated code excerpts

2e631cf

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024

auto-submit bot merged commit 9c294ef into flutter:main Nov 12, 2024
76 checks passed

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Packages from 72356fda4684 to 9c294efb9eb4 (12 revisions) flutter/flutter#158514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024

9c294efb9 [go_router] Add support for preloading branches of Stateful…

81990d6

…ShellRoute (revised solution) (flutter/packages#6467)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 67d8b50c1796 (18 revisions) flutter/flutter#158586

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

9c294efb9 [go_router] Add support for preloading branches of Stateful…

dfd4a2c

…ShellRoute (revised solution) (flutter/packages#6467)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 26e123a6ce03 (19 revisions) flutter/flutter#158626

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

9c294efb9 [go_router] Add support for preloading branches of Stateful…

f67fdb4

…ShellRoute (revised solution) (flutter/packages#6467)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

tolo commented Apr 5, 2024

chunhtai commented Apr 29, 2024

tolo commented Apr 30, 2024

cedvdb May 22, 2024

tolo May 27, 2024

unacorbatanegra commented May 30, 2024

chunhtai left a comment

chunhtai Jun 7, 2024

tolo Jun 10, 2024

tolo Jun 18, 2024

chunhtai Jul 16, 2024

chunhtai Jul 16, 2024

tolo Aug 15, 2024

cedvdb commented Jul 3, 2024

tolo commented Jul 10, 2024

chunhtai commented Jul 11, 2024

chunhtai Jul 16, 2024

chunhtai Jul 16, 2024

Shunt22 commented Aug 2, 2024

tolo commented Aug 19, 2024

cedvdb Aug 20, 2024

tolo Aug 30, 2024

cedvdb commented Sep 16, 2024 •

edited

Loading

tolo commented Sep 17, 2024

chunhtai left a comment

hannah-hyj left a comment

Shunt22 commented Oct 24, 2024

chunhtai commented Nov 7, 2024

cedvdb commented Nov 7, 2024

auto-submit bot commented Nov 7, 2024

chunhtai commented Nov 7, 2024

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

[go_router] Add support for preloading branches of StatefulShellRoute (revised solution) #6467

Conversation

tolo commented Apr 5, 2024

Pre-launch Checklist

chunhtai commented Apr 29, 2024

tolo commented Apr 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unacorbatanegra commented May 30, 2024

chunhtai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cedvdb commented Jul 3, 2024

tolo commented Jul 10, 2024

chunhtai commented Jul 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shunt22 commented Aug 2, 2024

tolo commented Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cedvdb commented Sep 16, 2024 • edited Loading

tolo commented Sep 17, 2024

chunhtai left a comment

Choose a reason for hiding this comment

hannah-hyj left a comment

Choose a reason for hiding this comment

Shunt22 commented Oct 24, 2024

chunhtai commented Nov 7, 2024

cedvdb commented Nov 7, 2024

auto-submit bot commented Nov 7, 2024

chunhtai commented Nov 7, 2024

cedvdb commented Sep 16, 2024 •

edited

Loading