[in_app_purchase] Add expiration date to Transaction #8030

feinstein · 2024-11-07T01:11:44Z

Exposes the Transaction's expiration date, so this information can be used on the dart side.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2024-11-07T01:11:48Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hellohuanlin

Can you provide more details in PR description?

hellohuanlin · 2024-11-07T18:15:44Z

...in_app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/StoreKit2Translators.swift

@@ -188,14 +188,15 @@ extension Product.PurchaseResult {
 extension Transaction {
  func convertToPigeon(restoring: Bool = false) -> SK2TransactionMessage {

-    let dateFromatter: DateFormatter = DateFormatter()
-    dateFromatter.dateFormat = "yyyy-MM-dd HH:mm:ss"
+    let dateFormatter: DateFormatter = DateFormatter()


nit: let dateFormatter = DateFormatter()

(@feinstein we know you didn't write this and are just fixing the typo, but while you're here... 🙂 )

Sure, will update shortly. Just keep in mind I am not a swift dev, so snippets like this one are really helpful!

LouiseHsu

lgtm! just a couple nits about the pubspec.

LouiseHsu · 2024-11-07T18:19:28Z

packages/in_app_purchase/in_app_purchase/example/pubspec.yaml

@@ -28,3 +28,8 @@ dev_dependencies:

 flutter:
  uses-material-design: true
+


I think these are triggering the repo check failures, you shouldn't need a these overrides

I was under the impression, from the CONTRIBUITING docs, that we first send a PR with dependencies overrides, created by the repo tool, so all packages and examples can be tested with the latest changes. Then after the PR is approved I remove those in a new PR: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins But maybe I got it wrong?

I was under the impression, from the CONTRIBUITING docs, that we first send a PR with dependencies overrides, created by the repo tool

That's for changes that span multiple packages; this PR only affects one package.

Ah, I see, thanks, I thought it was needed to test the packages, using local references.

LouiseHsu · 2024-11-07T18:20:01Z

packages/in_app_purchase/in_app_purchase/pubspec.yaml

@@ -42,3 +42,8 @@ screenshots:
    path: doc/iap_ios.gif
  - description: 'Example of in-app purchase on android'
    path: doc/iap_android.gif
+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins


this one can be removed too! The only pubspec.yaml change that this PR needs is the one in in_app_purchase_storekit

feinstein · 2024-11-08T06:15:04Z

Can you provide more details in PR description?

Done.

jmagman

Dang merge conflict with #7964. Can you regenerate the files as needed and bump the version and update CHANGELOG again? Sorry I know that's annoying.

feinstein · 2024-11-12T01:13:37Z

Dang merge conflict with #7964. Can you regenerate the files as needed and bump the version and update CHANGELOG again? Sorry I know that's annoying.

It's ok, part of the life of a dev

Make expirationDate non-required

Format dart code

stuartmorgan · 2024-11-12T21:04:00Z

Reviewers, is this ready to autosubmit, or are there pending final reviews?

LouiseHsu · 2024-11-12T21:06:28Z

Reviewers, is this ready to autosubmit, or are there pending final reviews?

LGTM! @feinstein you can add the autosubmit label when you're ready to merge.

stuartmorgan · 2024-11-12T21:11:13Z

@LouiseHsu Only project members can add labels; the final reviewer should add the label for non-member contributions.

It looks like the PR that I just landed re-broke the version change; I'll fix that and add the label.

stuartmorgan · 2024-11-12T21:14:26Z

(Reviewers, please remember as part of review to check that the type of the version increment follows semver; new public API additions are minor version changes, not bugfixes.)

feinstein · 2024-11-12T21:33:53Z

@stuartmorgan I though that would be the case, but when I saw past entries in the changelog the last ones were just incrementing patch, so I followed this. Thanks for the review and fixing it :).

…er/packages#8030)

flutter/packages@72356fd...26e123a 2024-11-13 dasyad00@gmail.com [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 39979207+ThangVuNguyenViet@users.noreply.github.com [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 pq@users.noreply.github.com [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 feinstein@users.noreply.github.com [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 stuartmorgan@google.com [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 ditman@gmail.com [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 stuartmorgan@google.com [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 tobias@leafnode.se [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 stuartmorgan@google.com [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 engine-flutter-autoroll@skia.org Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 magder@google.com Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 stuartmorgan@google.com [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 stuartmorgan@google.com [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 stuartmorgan@google.com [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 magder@google.com Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 43054281+camsim99@users.noreply.github.com [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 magder@google.com Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 37028599+EArminjon@users.noreply.github.com [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 stuartmorgan@google.com [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

feinstein requested review from LouiseHsu and bparrishMines as code owners November 7, 2024 01:11

github-actions bot added p: in_app_purchase platform-ios platform-macos labels Nov 7, 2024

feinstein force-pushed the iap-add-expiration-date branch from c882310 to c64a7b2 Compare November 7, 2024 01:30

hellohuanlin approved these changes Nov 7, 2024

View reviewed changes

LouiseHsu approved these changes Nov 7, 2024

View reviewed changes

stuartmorgan added the triage-ios Should be looked at in iOS triage label Nov 8, 2024

feinstein force-pushed the iap-add-expiration-date branch from 1b1ed7a to c36dbcf Compare November 11, 2024 06:27

LouiseHsu mentioned this pull request Nov 11, 2024

[in_app_purchase] Use StoreKit 2 APIs flutter/flutter#116383

Open

jmagman reviewed Nov 12, 2024

View reviewed changes

feinstein added 2 commits November 12, 2024 12:18

Add expiration date to Transaction

d1ddd46

Make expirationDate non-required

Refactor dateFormatter declaration

868f004

feinstein force-pushed the iap-add-expiration-date branch from c36dbcf to 6f60a58 Compare November 12, 2024 01:30

feinstein added 2 commits November 12, 2024 13:51

Fix merge conflict

fe60bd2

Format dart code

Bump version and add changelog

e278b88

feinstein force-pushed the iap-add-expiration-date branch from 64663e3 to e278b88 Compare November 12, 2024 02:52

stuartmorgan added 2 commits November 12, 2024 16:12

Re-bump version, as minor

e0c9b3e

Merge branch 'main' into iap-add-expiration-date

8bf3826

stuartmorgan added autosubmit Merge PR when tree becomes green via auto submit App and removed triage-ios Should be looked at in iOS triage labels Nov 12, 2024

auto-submit bot merged commit c77ab99 into flutter:main Nov 12, 2024
77 checks passed

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024

feinstein deleted the iap-add-expiration-date branch November 12, 2024 23:40

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 67d8b50c1796 (18 revisions) flutter/flutter#158586

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

c77ab99ab [in_app_purchase] Add expiration date to Transaction (flutt…

6a128f2

…er/packages#8030)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 26e123a6ce03 (19 revisions) flutter/flutter#158626

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

c77ab99ab [in_app_purchase] Add expiration date to Transaction (flutt…

78555d5

…er/packages#8030)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase] Add expiration date to Transaction #8030

[in_app_purchase] Add expiration date to Transaction #8030

feinstein commented Nov 7, 2024 •

edited

Loading

google-cla bot commented Nov 7, 2024

hellohuanlin left a comment

hellohuanlin Nov 7, 2024

jmagman Nov 7, 2024 •

edited

Loading

feinstein Nov 8, 2024

feinstein Nov 8, 2024

LouiseHsu left a comment

LouiseHsu Nov 7, 2024

feinstein Nov 8, 2024

stuartmorgan Nov 8, 2024

feinstein Nov 11, 2024

feinstein Nov 11, 2024

LouiseHsu Nov 7, 2024

feinstein Nov 11, 2024

feinstein commented Nov 8, 2024

jmagman left a comment

feinstein commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024

LouiseHsu commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024 •

edited

Loading

feinstein commented Nov 12, 2024

		@@ -28,3 +28,8 @@ dev_dependencies:

		flutter:
		uses-material-design: true

[in_app_purchase] Add expiration date to Transaction #8030

[in_app_purchase] Add expiration date to Transaction #8030

Conversation

feinstein commented Nov 7, 2024 • edited Loading

Pre-launch Checklist

google-cla bot commented Nov 7, 2024

hellohuanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmagman Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LouiseHsu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feinstein commented Nov 8, 2024

jmagman left a comment

Choose a reason for hiding this comment

feinstein commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024

LouiseHsu commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024

stuartmorgan commented Nov 12, 2024 • edited Loading

feinstein commented Nov 12, 2024

feinstein commented Nov 7, 2024 •

edited

Loading

jmagman Nov 7, 2024 •

edited

Loading

stuartmorgan commented Nov 12, 2024 •

edited

Loading