Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] docs: fix flutter run command for Stateful Nested Navigation #7158

Conversation

se09deluca
Copy link
Contributor

@se09deluca se09deluca commented Jul 18, 2024

There was a typo or out-of-date reference to a dart file in the go router example of Stateful Nested Navigation.

This PR fix the name of the file in the flutter run command.

Resolve issue 151961

Pre-launch Checklist

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj July 18, 2024 21:32
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 18, 2024
@chunhtai
Copy link
Contributor

no change log and version needed

reason: It is a doc that won't get published to api doc or pubdev

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
Copy link
Contributor

auto-submit bot commented Jul 18, 2024

auto label is removed for flutter/packages/7158, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
@auto-submit auto-submit bot merged commit 1d37e25 into flutter:main Jul 18, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@c7f0526...3144ac0

2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: go_router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong filename reference in command to launch go_router's example app
3 participants