[in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages into iap-tests-paymentqueueDelete
LouiseHsu
commented
Jul 18, 2024
| @@ -13,8 +13,8 @@ | |||
|
|
|||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| API_AVAILABLE(ios(13)) | |||
| API_UNAVAILABLE(tvos, macos, watchos) | |||
| API_AVAILABLE(ios(13), macos(10.15)) | |||
There was a problem hiding this comment.
This should've always been here. When mac support first got added i think this got missed here
For some reason the objc macos tests still ran fine even though it was using FIAPPaymentQueueDelegate which was technically unavailable, but when i rewrote the tests in swift, the compiler complained.
Adding this should be fine as its a wrapper over SKPaymentQueueDelegate and mac is supported
LouiseHsu
changed the title
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2024
flutter/packages@c7f0526...3144ac0 2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172) 2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170) 2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158) 2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668) 2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962) 2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@c7f0526...3144ac0 2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172) 2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170) 2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158) 2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668) 2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962) 2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@c7f0526...3144ac0 2024-07-19 louisehsu@google.com [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172) 2024-07-18 louisehsu@google.com [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170) 2024-07-18 53230888+se09deluca@users.noreply.github.com [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158) 2024-07-18 louisehsu@google.com [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704) 2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668) 2024-07-18 tarrinneal@gmail.com [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962) 2024-07-18 reidbaker@google.com [file_selector_android] Use Espresso 4.0 (flutter/packages#7159) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#151624
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).