[pigeon] adds support for non nullable types in collections #7547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
force-pushed
the
custom-codecs-6-return-of-the-collections
branch
2 times, most recently
from
e20fe67 to
29bec8d
Compare
tarrinneal
changed the title
tarrinneal
force-pushed
the
custom-codecs-6-return-of-the-collections
branch
from
dbc913d to
ae27688
Compare
stuartmorgan
requested changes
Sep 12, 2024
packages/pigeon/platform_tests/shared_test_plugin_code/lib/test_types.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/shared_test_plugin_code/lib/test_types.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/shared_test_plugin_code/lib/test_types.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
approved these changes
Sep 13, 2024
| //for (int i = 0; i < allNullableTypesOne.listList!.length; i++) { | ||
| // expect(listEquals(allNullableTypesOne.listList![i], allNullableTypesTwo.listList![i]), | ||
| // true); | ||
| //} |
There was a problem hiding this comment.
It's still not fixed, but the next pr will re-add a version of this. Then I'll add a more robust test in the final sequel.
There was a problem hiding this comment.
🤦🏻 Somehow I mis-parsed this as enabling the test rather than removing it.
It's still not fixed, but the next pr will re-add a version of this.
👍🏻
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2024
flutter/packages@330581f...df88c81 2024-09-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Improve flaky scroll tests (flutter/packages#7621) 2024-09-13 kevmoo@users.noreply.github.com Bump deps (flutter/packages#7357) 2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565) 2024-09-13 109111084+yaakovschectman@users.noreply.github.com [many] Update example android apps to target SDK level 34. (flutter/packages#7587) 2024-09-13 tarrinneal@gmail.com [pigeon] adds support for non nullable types in collections (flutter/packages#7547) 2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411) 2024-09-13 engine-flutter-autoroll@skia.org Roll Flutter from 303f222 to 2d30fe4 (21 revisions) (flutter/packages#7646) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pigeon] adds support for non nullable types in collections
fixes flutter/flutter#97848