[webview_flutter] Improve flaky scroll tests #7621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
added
the
autosubmit
|
It looks like we probably need to revert this and try again; post-submit has failed on three machines due to |
stuartmorgan
added a commit
that referenced
this pull request
Sep 16, 2024
This reverts commit df88c81.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2024
flutter/packages@330581f...df88c81 2024-09-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Improve flaky scroll tests (flutter/packages#7621) 2024-09-13 kevmoo@users.noreply.github.com Bump deps (flutter/packages#7357) 2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565) 2024-09-13 109111084+yaakovschectman@users.noreply.github.com [many] Update example android apps to target SDK level 34. (flutter/packages#7587) 2024-09-13 tarrinneal@gmail.com [pigeon] adds support for non nullable types in collections (flutter/packages#7547) 2024-09-13 mhvdijk@gmail.com [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411) 2024-09-13 engine-flutter-autoroll@skia.org Roll Flutter from 303f222 to 2d30fe4 (21 revisions) (flutter/packages#7646) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
tarrinneal
pushed a commit
that referenced
this pull request
Sep 17, 2024
Reverts #7621 The re-enabled tests are failing in post-submit. Alternately, instead of reverting we could just re-add the skips with the link, if we still want to keep the updated version as a better foundation to work from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebView portion of flutter/flutter#154826
Changes the scroll tests to wait for the
onScrollChangecallback to verify the scroll position rather than usinggetScrollPositionimmediately.Also split
getScrollPosition,scrollTo, andscrollByinto their own tests.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.