-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list #9429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list #9429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, i dont even remember writing that todo 😞
lgtm!
I wrote that one 🙂 |
|
A reason for requesting a revert of flutter/packages/9429 could |
|
Reason for revert: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout |
…lusion list (#9429)" (#9507) Reverts: #9429 Initiated by: jmagman Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout Original PR Author: jmagman Reviewed By: {LouiseHsu} This change reverts the following previous change: StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
flutter/packages@2c8d2bc...4841ada 2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Check macOS 15 for Xcode analyzer warnings (#9427)" (flutter/packages#9509) 2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (#9429)" (flutter/packages#9507) 2025-06-26 magder@google.com [ci] Check macOS 15 for Xcode analyzer warnings (flutter/packages#9427) 2025-06-26 magder@google.com [ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter/packages#9429) 2025-06-26 stuartmorgan@google.com [google_sign_in] Add contributor setup instructions (flutter/packages#9489) 2025-06-26 stuartmorgan@google.com [google_sign_in] Use an activity for credential requests (flutter/packages#9497) 2025-06-26 engine-flutter-autoroll@skia.org Roll Flutter from d733bea to 2773c0c (42 revisions) (flutter/packages#9495) 2025-06-26 stuartmorgan@google.com [extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7 (flutter/packages#9484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#171292) flutter/packages@2c8d2bc...4841ada 2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Check macOS 15 for Xcode analyzer warnings (flutter#9427)" (flutter/packages#9509) 2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter#9429)" (flutter/packages#9507) 2025-06-26 magder@google.com [ci] Check macOS 15 for Xcode analyzer warnings (flutter/packages#9427) 2025-06-26 magder@google.com [ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter/packages#9429) 2025-06-26 stuartmorgan@google.com [google_sign_in] Add contributor setup instructions (flutter/packages#9489) 2025-06-26 stuartmorgan@google.com [google_sign_in] Use an activity for credential requests (flutter/packages#9497) 2025-06-26 engine-flutter-autoroll@skia.org Roll Flutter from d733bea to 2773c0c (42 revisions) (flutter/packages#9495) 2025-06-26 stuartmorgan@google.com [extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7 (flutter/packages#9484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…st (flutter#9429) StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…lusion list (flutter#9429)" (flutter#9507) Reverts: flutter#9429 Initiated by: jmagman Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout Original PR Author: jmagman Reviewed By: {LouiseHsu} This change reverts the following previous change: StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3