[interactive_media_ads] Adds support to set general SDK settings

[bparrishMines]

Adds support for:

https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/api/reference/com/google/ads/interactivemedia/v3/api/ImaSdkSettings.html
https://developers.google.com/interactive-media-ads/docs/sdks/ios/client-side/reference/Classes/IMASettings.html

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request introduces a significant feature to configure the IMA SDK using a new ImaSettings class. The changes are well-structured and span across the Dart API, platform interfaces, and native implementations for both Android and iOS. The addition of PigeonOverrides for improved testability is a welcome enhancement. I've identified a couple of issues related to correctness and platform consistency, along with a suggestion to improve code maintainability. Overall, this is a solid contribution.

[gemini-code-assist]

This assertion will cause a runtime error if playerVersion is null. The method signature setPlayerVersion(String? playerVersion) correctly indicates that null is a valid value, and the underlying Pigeon-generated method also accepts a nullable String.

Please remove the assertion to allow null values to be passed to the native side, which aligns with the nullability of the parameter.

  @override
  Future<void> setPlayerVersion(String? playerVersion) async {
    final ImaSdkSettings settings = await nativeSettingsFuture;
    await settings.setPlayerVersion(playerVersion);
  }

[gemini-code-assist]

Many methods in this class follow the same pattern of awaiting nativeSettingsFuture and then calling a single method on the resulting settings object. This leads to some repetitive code.

To improve maintainability and reduce boilerplate, consider introducing a private helper method to encapsulate this pattern. For example:

Future<void> _withSettings(Future<void> Function(ImaSdkSettings) callback) async {
  final ImaSdkSettings settings = await nativeSettingsFuture;
  await callback(settings);
}

You could then refactor the methods like this:

@override
Future<void> setAutoPlayAdBreaks(bool autoPlayAdBreaks) {
  return _withSettings(
    (ImaSdkSettings settings) => settings.setAutoPlayAdBreaks(autoPlayAdBreaks),
  );
}

[gemini-code-assist]

When sessionID is null, it is being converted to an empty string (''). However, the Android implementation passes null through to the native side. The native iOS property sessionID is also nullable (String?), so it should be able to handle nil.

To maintain consistency between platforms and align with the native SDK's nullability, it's better to pass sessionID directly without the null-coalescing operator.

    return nativeSettings.setSessionID(sessionID);

[gemini-code-assist]

The documentation for this factory constructor is incorrect. It states that it creates a PlatformAdsManagerDelegate, but it actually creates a PlatformContentProgressProvider. This seems to be a copy-paste error.

  /// Creates a new [PlatformContentProgressProvider].

[stuartmorgan-g]

LGTM

[stuartmorgan-g]

Nice.

[stuartmorgan-g]

Why is it called initSettings if it's creating a new settings object every time? The name implies initializing some shared state.

[stuartmorgan-g]

Comment about why this is unawaited?

[stuartmorgan-g]

Same naming question here.