[interactive_media_ads] Adds support to set general SDK settings #9648
+2,785
−88
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async'; | ||
|
|
||
| import 'package:meta/meta.dart'; | ||
|
|
||
| import '../platform_interface/platform_ima_settings.dart'; | ||
| import 'interactive_media_ads.g.dart'; | ||
|
|
||
| /// Android implementation of [PlatformImaSettings]. | ||
| final class AndroidImaSettings extends PlatformImaSettings { | ||
| /// Constructs an [AndroidImaSettings]. | ||
| AndroidImaSettings(super.params) : super.implementation(); | ||
|
|
||
| /// The native Android ImaSdkSettings. | ||
| /// | ||
| /// Defines general SDK settings that are used when creating an `AdsLoader`. | ||
| @internal | ||
| late final Future<ImaSdkSettings> nativeSettingsFuture = _createSettings(); | ||
|
|
||
| @override | ||
| Future<void> setAutoPlayAdBreaks(bool autoPlayAdBreaks) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setAutoPlayAdBreaks(autoPlayAdBreaks); | ||
| } | ||
|
Comment on lines
+24
to
+27
There was a problem hiding this comment. Many methods in this class follow the same pattern of awaiting To improve maintainability and reduce boilerplate, consider introducing a private helper method to encapsulate this pattern. For example: Future<void> _withSettings(Future<void> Function(ImaSdkSettings) callback) async {
final ImaSdkSettings settings = await nativeSettingsFuture;
await callback(settings);
}You could then refactor the methods like this: @override
Future<void> setAutoPlayAdBreaks(bool autoPlayAdBreaks) {
return _withSettings(
(ImaSdkSettings settings) => settings.setAutoPlayAdBreaks(autoPlayAdBreaks),
);
} |
||
|
|
||
| @override | ||
| Future<void> setDebugMode(bool enabled) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setDebugMode(enabled); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setFeatureFlags(Map<String, String> featureFlags) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setFeatureFlags(featureFlags); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setMaxRedirects(int maxRedirects) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setMaxRedirects(maxRedirects); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setPlayerType(String playerType) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setPlayerType(playerType); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setPlayerVersion(String playerVersion) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setPlayerVersion(playerVersion); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setPpid(String ppid) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setPpid(ppid); | ||
| } | ||
|
|
||
| @override | ||
| Future<void> setSessionID(String sessionID) async { | ||
| final ImaSdkSettings settings = await nativeSettingsFuture; | ||
| await settings.setSessionId(sessionID); | ||
| } | ||
|
|
||
| Future<ImaSdkSettings> _createSettings() async { | ||
| final ImaSdkSettings settings = | ||
| await ImaSdkFactory.instance.createImaSdkSettings(); | ||
| if (params.language case final String language) { | ||
| await settings.setLanguage(language); | ||
| } | ||
| return settings; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.