Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Add documentation #2303

Merged
merged 9 commits into from
Dec 3, 2019
Merged

[google_maps_flutter] Add documentation #2303

merged 9 commits into from
Dec 3, 2019

Conversation

bparrishMines
Copy link
Contributor

Description

Add documentation to google maps plugin.

Related Issues

flutter/flutter#44390

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines requested a review from mklim November 25, 2019 20:56
mklim
mklim reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you also add an analysis_options.yaml file to the plugin linting for this to prevent it from regressing going forward? There's an example you can copy in android_intent. You can test with it locally by running pub global run tuneup.

@mklim
Copy link
Contributor

mklim commented Nov 26, 2019

Thanks for this! Could you also add an analysis_options.yaml file to the plugin linting for this to prevent it from regressing going forward? There's an example you can copy in android_intent. You can test with it locally by running pub global run tuneup.

Actually now that #2300 has been merged, the better thing to do would be to pull in master and then remove the google_maps_flutter/analysis_options.yaml from there. That PR applied the public_members_api lint globally to all plugins and added exclusions for already failing cases like this one so that it could land. So now that it's merged it would be better to remove the exclusion.

ened
ened approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@ened ened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bparrishMines bparrishMines merged commit 09d9f01 into flutter:master Dec 3, 2019
@bparrishMines bparrishMines deleted the maps_docs branch December 3, 2019 21:13
@bparrishMines bparrishMines mentioned this pull request Dec 4, 2019
Closed
2 tasks
daohoangson added a commit to daohoangson/plugins that referenced this pull request Dec 7, 2019
@daohoangson
Merge commit 'be71485431cd5ebaeb7cad4c57ddeb0be910d8b6' into webview_…
18a31a0 
…flutter/has_gesture

* commit 'be71485431cd5ebaeb7cad4c57ddeb0be910d8b6': (74 commits)
  [webview_flutter] Add support for onPageStarted event (flutter#2295)
  adds missing [[ to elif statement in scripts/incremental_build.sh (flutter#2358)
  [none] Pass --custom-analysis flag through CI (flutter#2356)
  [video_player] Document public API of video_player_platform_interface. (flutter#2355)
  [none] Lock pedantic version (flutter#2354)
  [video_player_platform_interface] Fix some pedantic lints (flutter#2349)
  Export SignInOption from interface since it is used in the frontend (flutter#2350)
  Update documentation for connectivity (flutter#2328)
  [ android_alarm_manager ] Loosen Flutter SDK lower bound, update README (flutter#2338)
  [e2e_macos] Remove redundant analysis_options.yaml (flutter#2347)
  Revert "[android_alarm_manager] Update minimum Flutter version to 1.12.0 (flutter#2327)" (flutter#2345)
  [video_player] Add web implementation using platform interface (flutter#2279)
  [webview_flutter] Fix pedantic lint errors (flutter#2322)
  [google_maps_flutter] Add documentation (flutter#2303)
  [e2e] Fix pedantic lints (flutter#2315)
  [video_player] Fix pedantic lints (flutter#2321)
  [share] Fix pedantic lints (flutter#2320)
  [battery] Fix pedantic linter errors (flutter#2311)
  [device_info] Fix pedantic errors (flutter#2314)
  [in_app_purchase] Fix most failing pedantic lints (flutter#2317)
  ...

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/lib/webview_flutter.dart
#	packages/webview_flutter/pubspec.yaml
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@bparrishMines
[google_maps_flutter] Add documentation (flutter#2303)
4fc955e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mklim mklim mklim left review comments

@ened ened ened approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
cla: yes documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bparrishMines @mklim @ened @googlebot