[android_alarm_manager] Update minimum Flutter version to 1.12.0 #2327
Conversation
|
Can you update the CHANGELOG (referencing the new functionality used?) and bump the version? |
That was done in the previous PR here: #2193 I seemed to have missed this TODO before merging that. |
|
You have my approval to merge and publish this as a late-breaking fix to the previous unpublished version. |
|
@bkonyi @collinjackson this is causing our CI to go red because I'm kind of surprised this PR passed CI initially, there may be a bug in what tests initially ran on this PR. When testing locally it looks like everything works with v1.9.1, including the e2e tests and the logs from the example app. What here needs to be v1.12? |
|
Discussed offline, the bound here was introduced just to guard against v2 embedding code. Unfortunately we don't have a way to version the embedding that but so far we've been relying on documentation on the higher minimum bound for when developers use that path (flutter/flutter#42792). @bkonyi is going to put up a PR lowering this minimum bound back to stable. |
…flutter/has_gesture * commit 'be71485431cd5ebaeb7cad4c57ddeb0be910d8b6': (74 commits) [webview_flutter] Add support for onPageStarted event (flutter#2295) adds missing [[ to elif statement in scripts/incremental_build.sh (flutter#2358) [none] Pass --custom-analysis flag through CI (flutter#2356) [video_player] Document public API of video_player_platform_interface. (flutter#2355) [none] Lock pedantic version (flutter#2354) [video_player_platform_interface] Fix some pedantic lints (flutter#2349) Export SignInOption from interface since it is used in the frontend (flutter#2350) Update documentation for connectivity (flutter#2328) [ android_alarm_manager ] Loosen Flutter SDK lower bound, update README (flutter#2338) [e2e_macos] Remove redundant analysis_options.yaml (flutter#2347) Revert "[android_alarm_manager] Update minimum Flutter version to 1.12.0 (flutter#2327)" (flutter#2345) [video_player] Add web implementation using platform interface (flutter#2279) [webview_flutter] Fix pedantic lint errors (flutter#2322) [google_maps_flutter] Add documentation (flutter#2303) [e2e] Fix pedantic lints (flutter#2315) [video_player] Fix pedantic lints (flutter#2321) [share] Fix pedantic lints (flutter#2320) [battery] Fix pedantic linter errors (flutter#2311) [device_info] Fix pedantic errors (flutter#2314) [in_app_purchase] Fix most failing pedantic lints (flutter#2317) ... # Conflicts: # packages/webview_flutter/CHANGELOG.md # packages/webview_flutter/lib/platform_interface.dart # packages/webview_flutter/lib/webview_flutter.dart # packages/webview_flutter/pubspec.yaml
…2.0 (flutter#2327)" (flutter#2345) This reverts commit 9d367d6.
…2.0 (flutter#2327)" (flutter#2345) This reverts commit 9d367d6.
This plugin relies partially on functionality which will be available in the next Flutter release.