This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] ios: re-enable test with popup #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait until flutter/engine#32820 going to stable before we can land this, so that the test can pass on both stable and master |
|
The engine roll commit is: flutter/flutter@dd65b6b We can merge when is commit is in stable branch. |
That day is upon us :) |
cyanglaz
force-pushed
the
enable_google_map_interface_test
branch
from
94c585a to
f0ff4e7
Compare
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 1, 2022
* e911e0564 b8f7f1f [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (#115856) (flutter/plugins#6751) * bdf1a98a1 Roll Flutter from 0eb2d51 to cb23473 (13 revisions) (flutter/plugins#6755) * 614d7c0df Roll Flutter from cb23473 to ff59250 (3 revisions) (flutter/plugins#6757) * 2be1da958 Roll Flutter from ff59250 to 17c1dbc (31 revisions) (flutter/plugins#6764) * 381541628 [in_app_purchase_storekit] Add support for macOS (flutter/plugins#6517) * eb796fe2e Roll Flutter from 17c1dbc to b2672fe (26 revisions) (flutter/plugins#6766) * 89ad5a9d6 enable test (flutter/plugins#5312)
|
This seems to be breaking the tree? |
cyanglaz
pushed a commit
that referenced
this pull request
Dec 2, 2022
11 tasks
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…#116356) * e911e0564 b8f7f1f [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (flutter#115856) (flutter/plugins#6751) * bdf1a98a1 Roll Flutter from 0eb2d51 to cb23473 (13 revisions) (flutter/plugins#6755) * 614d7c0df Roll Flutter from cb23473 to ff59250 (3 revisions) (flutter/plugins#6757) * 2be1da958 Roll Flutter from ff59250 to 17c1dbc (31 revisions) (flutter/plugins#6764) * 381541628 [in_app_purchase_storekit] Add support for macOS (flutter/plugins#6517) * eb796fe2e Roll Flutter from 17c1dbc to b2672fe (26 revisions) (flutter/plugins#6766) * 89ad5a9d6 enable test (flutter/plugins#5312)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#116356) * e911e0564 b8f7f1f [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (flutter#115856) (flutter/plugins#6751) * bdf1a98a1 Roll Flutter from 0eb2d51 to cb23473 (13 revisions) (flutter/plugins#6755) * 614d7c0df Roll Flutter from cb23473 to ff59250 (3 revisions) (flutter/plugins#6757) * 2be1da958 Roll Flutter from ff59250 to 17c1dbc (31 revisions) (flutter/plugins#6764) * 381541628 [in_app_purchase_storekit] Add support for macOS (flutter/plugins#6517) * eb796fe2e Roll Flutter from 17c1dbc to b2672fe (26 revisions) (flutter/plugins#6766) * 89ad5a9d6 enable test (flutter/plugins#5312)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116356) * e911e0564 b8f7f1f [flutter_releases] Flutter stable 3.3.9 Framework Cherrypicks (flutter#115856) (flutter/plugins#6751) * bdf1a98a1 Roll Flutter from 0eb2d51 to cb23473 (13 revisions) (flutter/plugins#6755) * 614d7c0df Roll Flutter from cb23473 to ff59250 (3 revisions) (flutter/plugins#6757) * 2be1da958 Roll Flutter from ff59250 to 17c1dbc (31 revisions) (flutter/plugins#6764) * 381541628 [in_app_purchase_storekit] Add support for macOS (flutter/plugins#6517) * eb796fe2e Roll Flutter from 17c1dbc to b2672fe (26 revisions) (flutter/plugins#6766) * 89ad5a9d6 enable test (flutter/plugins#5312)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This reverts commit 89ad5a9.
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…5312" (flutter#6783) * reland fix fix test for iOS 16 fix fix typos * format * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-able the test that triggers system alert as it seems not failing anymore in newest iOS versions.
fixes: flutter/flutter#93325
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.