This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Reland "[google_maps_flutter] ios: re-enable test with popup #5312" #6783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Dec 8, 2022
| [button tap]; | ||
| return; | ||
| } | ||
| XCUICoordinate *coordinate = [button coordinateWithNormalizedOffset:CGVectorMake(0, 0)]; |
There was a problem hiding this comment.
Hopefully this doesn't cause flakiness.
cyanglaz
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/plugins, pr: 6783, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
cyanglaz
force-pushed
the
reland_enable_google_map_interface_test
branch
from
8a22895 to
0ea7e3f
Compare
added 2 commits
December 12, 2022 09:50
cyanglaz
added
the
override: no versioning needed
|
No versioning update: PRs that only affect tests. |
cyanglaz
commented
Dec 12, 2022
| @@ -2,9 +2,9 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
|
|
|||
| @import CoreLocation; | |||
There was a problem hiding this comment.
We don't need the entire GoogleMaps sdk to run the tests. Only CoreLocation is necessary.
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2022
* 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup #5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116996) * 13818023c [camera] Attempt to fix flaky new Android test (flutter/plugins#6831) * da4321d01 [google_maps_flutter] Modified `README.md` to fix minor syntax issues (flutter/plugins#6631) * e8c9731f1 Roll Flutter from eefbe85 to bd0791b (25 revisions) (flutter/plugins#6832) * 2eb616545 Reland "[google_maps_flutter] ios: re-enable test with popup flutter#5312" (flutter/plugins#6783) * 738bd91d8 Update FlutterFire link (flutter/plugins#6835) * ec2041f82 Roll Flutter from bd0791b to 15af817 (27 revisions) (flutter/plugins#6837)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…5312" (flutter#6783) * reland fix fix test for iOS 16 fix fix typos * format * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #5312
The accessibility type for the flutter text buttons are changed from buttons to texts.
Fixes flutter/flutter#93325
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.