Fix : fullScreenByDefault does not work with autoPlay #710 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y#710 The first attempt to go full screen just after checking if `autoPlay` is on fails and prevents the second want to be done.
On some devices, the `VideoPlayerController` can be ready before the `Chewie` widget is. If that happens, the `enterFullScreen()` call does not work and the controller is out of sync believing it’s in full screen where it’s not. Fix attempt : We wait until we have at least one listener before trying to enter full screen
|
@maxbritto LGTM. |
maherjaafar
approved these changes
Apr 4, 2023
yutongluo
approved these changes
May 2, 2023
|
Do you need anything else from me until you can merge the PR ? |
|
@maxbritto Please re-sync your changes with Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first attempt to go full screen just after checking if
autoPlayis on fails and prevents the second want to be done.See bug reported here for more information #710