Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : fullScreenByDefault does not work with autoPlay #710 #711

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Feb 21, 2023

  1. Fix : fullScreenByDefault does not work with autoPlay fluttercommunit…

    …y#710
    
    The first attempt to go full screen just after checking if `autoPlay` is on fails and prevents the second want to be done.
    maxbritto committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4124d22 View commit details
    Browse the repository at this point in the history
  2. fix : fullScreenByDefault is unreliable

    On some devices, the `VideoPlayerController` can be ready before the `Chewie` widget is.
    If that happens, the `enterFullScreen()` call does not work and the controller is out of sync believing it’s in full screen where it’s not.
    
    Fix attempt : We wait until we have at least one listener before trying to enter full screen
    maxbritto committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4d58757 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    9926178 View commit details
    Browse the repository at this point in the history